Skip to content

Conversation

@mattseddon
Copy link
Contributor

@mattseddon mattseddon commented Aug 10, 2022

2/4 main <- #2164 <- this <- #2170 <-#2171

This PR gives users the ability to sort experiments by their starred status.

Demo

Screen.Recording.2022-08-10.at.12.32.38.pm.mov

@mattseddon mattseddon added the product PR that affects product label Aug 10, 2022
@mattseddon mattseddon self-assigned this Aug 10, 2022
@mattseddon mattseddon changed the base branch from main to filter-by-starred August 10, 2022 02:41
@mattseddon mattseddon marked this pull request as ready for review August 10, 2022 02:44
@qlty-cloud-legacy
Copy link

Code Climate has analyzed commit fa9e2b0 and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 2

The test coverage on the diff in this pull request is 97.5% (85% is the threshold).

This pull request will bring the total coverage in the repository to 96.8% (0.0% change).

View more on Code Climate.

@mattseddon
Copy link
Contributor Author

Related to #1720

Copy link
Contributor

@sroy3 sroy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not able to reproduce this locally with this branch. Are there files missing?

@sroy3
Copy link
Contributor

sroy3 commented Aug 10, 2022

I am not able to reproduce this locally with this branch. Are there files missing?

Nvm, it's the checkpoints I could not sort. I can sort the experiments. (not fully awake I guess)

Base automatically changed from filter-by-starred to main August 10, 2022 22:49
@mattseddon mattseddon enabled auto-merge (squash) August 10, 2022 22:51
@mattseddon mattseddon merged commit a4b4bbd into main Aug 10, 2022
@mattseddon mattseddon deleted the sort-by-starred branch August 10, 2022 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

product PR that affects product

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants