Skip to content

Conversation

@mattseddon
Copy link
Contributor

@mattseddon mattseddon commented Aug 10, 2022

4/4 main <- #2164 <- #2169 <-#2170 <- this

This PR adds a command to the palette and the experiments sort by tree view/title which will add the starred sort to the table sorts.

Demo

Screen.Recording.2022-08-10.at.1.45.10.pm.mov

@mattseddon mattseddon added the product PR that affects product label Aug 10, 2022
@mattseddon mattseddon self-assigned this Aug 10, 2022
@mattseddon mattseddon changed the base branch from main to add-filter-to-starred August 10, 2022 03:52
@mattseddon mattseddon marked this pull request as ready for review August 10, 2022 03:54
@mattseddon
Copy link
Contributor Author

Related to #1720

@qlty-cloud-legacy
Copy link

Code Climate has analyzed commit 04055a3 and detected 3 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1
Duplication 2

The test coverage on the diff in this pull request is 95.3% (85% is the threshold).

This pull request will bring the total coverage in the repository to 96.7% (0.0% change).

View more on Code Climate.

@mattseddon mattseddon force-pushed the add-filter-to-starred branch from 6b08d17 to 1603cea Compare August 10, 2022 23:08
Base automatically changed from add-filter-to-starred to main August 10, 2022 23:18
@mattseddon mattseddon force-pushed the add-sort-by-starred branch from 80456f6 to f7b3a18 Compare August 10, 2022 23:19
@mattseddon mattseddon enabled auto-merge (squash) August 10, 2022 23:19
@mattseddon mattseddon merged commit 55f45a2 into main Aug 10, 2022
@mattseddon mattseddon deleted the add-sort-by-starred branch August 10, 2022 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

product PR that affects product

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants