Fix experiment table live updates in non-checkpoint experiments #2203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattseddon
force-pushed
the
fix-live-metric-update
branch
from
7c295e6 to
b775b23
Compare
julieg18
approved these changes
Aug 17, 2022
sroy3
approved these changes
Aug 17, 2022
mattseddon
force-pushed
the
fix-live-metric-update
branch
from
b775b23 to
e80267d
Compare
mattseddon
force-pushed
the
fix-live-metric-update
branch
from
e80267d to
4edbebf
Compare
|
Code Climate has analyzed commit 4edbebf and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 96.7%. View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2/2
main<- #2202 <- thisThis PR fixes live updates in the experiments table for projects which use dvclive for logging.
Demo
Screen.Recording.2022-08-17.at.4.25.19.pm.mov
The bug was caused by files being moved from the watcher when they were deleted. When an experiment is started the
dvclive.json(or equivalent) file is deleted. This meant that until the experiment was finished the watcher would not be fired at all.