Skip to content

Fix partially hidden header context menus #2204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 17, 2022
Merged

Fix partially hidden header context menus #2204

merged 2 commits into from
Aug 17, 2022

Conversation

@julieg18
Copy link
Contributor

@julieg18 julieg18 commented Aug 17, 2022 •
edited
Loading

stops context menu from being blocked by the workspace row

Current:

image

PR:

image

Part of #2133 followup

@julieg18 julieg18 added the bug Something isn't working label Aug 17, 2022
@julieg18 julieg18 requested a review from mattseddon as a code owner August 17, 2022 15:29
@julieg18 julieg18 self-assigned this Aug 17, 2022
@julieg18 julieg18 requested review from sroy3 and wolmir as code owners August 17, 2022 15:29
julieg18
julieg18 commented Aug 17, 2022
View reviewed changes
webview/src/experiments/components/table/styles.module.scss
position: sticky;
top: 0;
z-index: 4;
z-index: 5;
Copy link
Contributor Author

@julieg18 julieg18 Aug 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed yet another small bug that I missed in #2133 😅. Looks like there was an issue with the z-index, causing the workspace row to have a higher stacking context than the head tooltips. Fixed by increasing the head z-index, making it higher than the workspace row.

Copy link
Contributor

@sroy3 sroy3 Aug 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fine as is, but setting the z indexes in variables might help keeping the indexes in order at a glance. That is if the workspace row has a set z-index.

@mattseddon mattseddon enabled auto-merge (squash) August 17, 2022 22:40
@qlty-cloud-legacy
Copy link

qlty-cloud-legacy bot commented Aug 17, 2022

Code Climate has analyzed commit 12ce90d and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (85% is the threshold).

This pull request will bring the total coverage in the repository to 96.7% (0.0% change).

View more on Code Climate.

@mattseddon mattseddon merged commit c174413 into main Aug 17, 2022
@mattseddon mattseddon deleted the fix-hidden-head-context-menu branch August 17, 2022 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wolmir wolmir Awaiting requested review from wolmir

2 more reviewers

@sroy3 sroy3 sroy3 approved these changes

@mattseddon mattseddon mattseddon approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@julieg18 julieg18

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@julieg18 @sroy3 @mattseddon