Share an experiment from context menus #2219
Conversation
mattseddon
force-pushed
the
share-experiment
branch
from
a9c8fef to
5203377
Compare
demo/dvc.yaml
Outdated
| deps: | ||
| - data/MNIST | ||
| - train.py | ||
| - data/MNIST/raw |
There was a problem hiding this comment.
[F] Change proposed here treeverse/dvc#8113 (comment)
| name | ||
| ) | ||
| await experiments.runCommand(AvailableCommands.PUSH, dvcRoot) | ||
| return Toast.showOutput(gitPushBranch(dvcRoot, input)) |
There was a problem hiding this comment.
[C] This makes me think that we should be showing all of the git commands that we run inside of our DVC output channel.
I will follow up and give Git its own reader/executor.
| 'Modify, Reset and Run', | ||
| 'Modify and Resume', | ||
| 'Modify and Queue', | ||
| 'Star Experiment', |
There was a problem hiding this comment.
I don't think 'Experiment' needs to be here. I'll follow up
| "title": "%command.views.experiments.shareExperiment%", | ||
| "command": "dvc.views.experiments.shareExperiment", | ||
| "category": "DVC", | ||
| "icon": "$(repo-push)" |
demo/dvc.yaml
Outdated
| deps: | ||
| - data/MNIST | ||
| - train.py | ||
| - data/MNIST/raw |
There was a problem hiding this comment.
will make this change separately
mattseddon
force-pushed
the
share-experiment
branch
from
41378cf to
3c181e5
Compare
|
Code Climate has analyzed commit 9b025f7 and detected 3 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 91.6% (85% is the threshold). This pull request will bring the total coverage in the repository to 96.6% (0.0% change). View more on Code Climate. |
3 participants
1/2
main<- this <- #2221This PR gives the user the option to share an experiment as a branch from the context menus available in the experiments tree and table.
Demo
Screen.Recording.2022-08-19.at.2.23.06.pm.mov
Note: There are a few things to follow up with in terms of outstanding housekeeping, I also want to add all calls to git into our output channel and add a new (matching) command to the palette. Next step after that is to add a "Commt and Share" command.