Skip to content

Conversation

@mattseddon
Copy link
Contributor

@mattseddon mattseddon commented Aug 22, 2022

Housekeeping follow-up from #2219. Noticed the inconsistency then but didn't want to bloat the PR anymore.

@mattseddon mattseddon force-pushed the replace-vary-with-modify branch from 91ddb36 to 866c222 Compare August 22, 2022 07:14
RegisteredCliCommands.EXPERIMENT_VIEW_BRANCH,
{ dvcRoot: this.dvcRoot, id: message.payload }
)
case MessageFromWebviewType.VARY_EXPERIMENT_PARAMS_AND_QUEUE:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[F] VARY is left over from a previous naming convention

@mattseddon mattseddon marked this pull request as ready for review August 22, 2022 07:22
@qlty-cloud-legacy
Copy link

Code Climate has analyzed commit 866c222 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (85% is the threshold).

This pull request will bring the total coverage in the repository to 96.6% (0.0% change).

View more on Code Climate.

@mattseddon mattseddon merged commit 9cca712 into main Aug 22, 2022
@mattseddon mattseddon deleted the replace-vary-with-modify branch August 22, 2022 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants