Fix size of flexible confusion matrix #2531
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattseddon
commented
Oct 5, 2022
| field: string | undefined, | ||
| isMultiView: boolean | ||
| ): string => { | ||
| const transformRevisionData = ( |
Contributor
Author
There was a problem hiding this comment.
[F] This change is good because we are not looping over the datapoints twice anymore.
mattseddon
force-pushed
the
fix-plot-size
branch
2 times, most recently
from
a54f201 to
9fb343f
Compare
Contributor
Author
|
I will fix any Code climate issues once the previous PR has been merged and it starts working again. |
sroy3
approved these changes
Oct 5, 2022
mattseddon
force-pushed
the
fix-plot-size
branch
from
9fb343f to
00cf805
Compare
![qlty-cloud-legacy[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| ): string => { | ||
| if (!field || (!isMultiView && !isConcatenatedField(field))) { | ||
| return JSON.stringify(datapoints) | ||
| const transformRevisionData = ( |
There was a problem hiding this comment.
Function transformRevisionData has 39 lines of code (exceeds 30 allowed). Consider refactoring.
|
Code Climate has analyzed commit 00cf805 and detected 1 issue on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 95.6% (85% is the threshold). This pull request will bring the total coverage in the repository to 96.9%. View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2/2
main<- #2523 <- thisThe plots webview uses the number of revisions provided for a confusion matrix to change the size of the plot being rendered. In order to fix the size problem, I have corrected the revisions provided in the webview in the message.
This is the line in the webview: https://github.com/iterative/vscode-dvc/blob/cf15eaa2d990211e9e1c10a5c592b14bc49f85ba/webview/src/plots/components/templatePlots/TemplatePlotsGrid.tsx#L111
Screenshot
Related to #2516