Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default for variables into docker-compose.yml #8

Merged
merged 2 commits into from Jul 18, 2021
Merged

Set default for variables into docker-compose.yml #8

merged 2 commits into from Jul 18, 2021

Conversation

potens1
Copy link
Contributor

@potens1 potens1 commented Jul 18, 2021

This way .env file is not required, but taken in account if present

That's another way to close #6

This way .env file is not required, but taken in account if present
@Ughuuu
Copy link
Contributor

Ughuuu commented Jul 18, 2021

Hm, interesting way of setting env without using the .env file. I like this more actually. Even tho I think it might be more difficult to find later on where all the env data is located.

@potens1
Copy link
Contributor Author

potens1 commented Jul 18, 2021

Let's say it's more a safe guard than anything, to ensure variables are set. Also, this could define THE default when bug reporting or posting backtesting results, and then everyone is free to override with .env

The two solutions (yours and mine) are not exclusives but more like a complement

I think also the download data should use the same timerange (in fact a bit wider to have the startup candles in it)

@potens1
Copy link
Contributor Author

potens1 commented Jul 18, 2021

Also, not sure AT ALL about the default open trades to 1 !

@iterativv
Copy link
Owner

Yes, could you change the default open trades to 5 ?

@potens1
Copy link
Contributor Author

potens1 commented Jul 18, 2021

Yes, it makes more sense

@iterativv iterativv merged commit 5c0c1fc into iterativv:main Jul 18, 2021
iterativv pushed a commit that referenced this pull request Sep 28, 2021
slightly modified stoploss from ng
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The .env file is missing from the repository
3 participants