Image Card: Allow promotional variant images to have dynamic height #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
on-behalf-of: @ithaka <dane.hillard@ithaka.org>
Lham42
approved these changes
Jul 15, 2021
SMQuazi
approved these changes
Jul 15, 2021
Merged
sirrah-tam
pushed a commit
to sirrah-tam/pharos
that referenced
this pull request
Dec 1, 2023
…ght (ithaka#165) on-behalf-of: @ithaka <dane.hillard@ithaka.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change: (check at least one)
Is this a breaking change? (check one)
Is the: (complete all)
What does this change address?
Promotional image cards are meant to allow for a broader range of possible images because they're hand-chosen. This means they should also be given room to be sized dynamically/bespoke.
How does this change work?
Remove the stringent
14remheight from promotional images. Images can be sized either with layouts or explicitly with CSS by the consumer.