Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close Tab button cannot be changed #114

Open
hackel opened this issue Sep 25, 2014 · 3 comments
Open

Close Tab button cannot be changed #114

hackel opened this issue Sep 25, 2014 · 3 comments

Comments

@hackel
Copy link

hackel commented Sep 25, 2014

Using Tab Utilities 1.5.21.1

Under Appearance, Show on tab bar, the option "[Close Tab] button" seems to have no effect. Checked or not, and regardless of which selection is enabled, the bahaviour is the same. I see the close button (x) on the active tab at all times, and also on pointed tabs. If I choose "on all tabs wider than", I can loweer the value and see close buttons on every tab, but it is just modifying browser.tabs.tabClipWidth so I think this is a built-in function?

My goal would be to have no close buttons at all unless I am explicitly pointing at a tab.
@RedHorizon
Copy link

I have this bug as well. FF32.0.3 and FF33, TU1.5.28.1
Reproduce steps:
Create new FF profile, install TU, go to options and select [Close Tab] button - "mouse hover" or whatever that option is called.
Close button will still be present on all tabs.

@phts
Copy link

phts commented Oct 17, 2014

The browser.tabs.closeButtons preference has been removed since Firefox 31.
Tab Utilities uses exactly this preference to change a close button.

More info

phts added a commit to phts/tabutils that referenced this issue Oct 17, 2014
@phts
Remove "Close Tab Button Position" functionality
b4172e5 
The `browser.tabs.closeButtons` preference has been removed since Firefox 31.
So this functionality became redundant.

Related to ithinc#114.
phts added a commit to phts/tabutils that referenced this issue Oct 17, 2014
@phts
Remove "Close Tab Button Position" functionality
4c2b338 
The `browser.tabs.closeButtons` preference has been removed since Firefox 31.
So this functionality became redundant.

Related to ithinc#114.
phts added a commit to phts/tabutils that referenced this issue Oct 18, 2014
@phts
Remove "Close Tab button" option and related functionality
ec53cf3 
The `browser.tabs.closeButtons` preference has been removed since Firefox 31.
So this functionality became redundant.

Related to ithinc#114.
phts added a commit to phts/tabutils that referenced this issue Oct 19, 2014
@phts
Add "Close Tab button" option functionality
d0749b2 
It implemented using own styles based on "closebuttons" attribute
of tabContainer.

Fixes ithinc#114.
phts added a commit to phts/tabutils that referenced this issue Oct 19, 2014
@phts
Add "Close Tab button" preference functionality
f167880 
It implemented using own styles based on "closebuttons" attribute
of tabContainer.

Fixes ithinc#114.
phts added a commit to phts/tabutils that referenced this issue Oct 19, 2014
@phts
Merge branch 'dev-closebuttons' into dev
818f082 
Implement "Close Tab button" preference functionality from scratch.

It doesn't contain "tab bar close button" related options.

Also it contains a new option "Browser default" which makes Close Tab
buttons behave in a browser default way and not being affected by
this extension.

Fixes ithinc#114.
@RedHorizon
Copy link

FF33, TU1.5.28.1 bug is reproduced as well.
Same reproduce steps:
Create new FF profile, install TU, go to options and select [Close Tab] button - "mouse hover" or whatever that option is called.
Close button will still be present on all tabs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hackel @phts @RedHorizon