Added markdownlint and prettier services to templates #111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turegjorup
approved these changes
Jun 25, 2025
rimi-itk
reviewed
Jun 25, 2025
Comment on lines
82
to
99
| markdownlint: | ||
| image: itkdev/markdownlint | ||
| profiles: | ||
| - dev | ||
| volumes: | ||
| - ./:/md | ||
|
|
||
| prettier: | ||
| # Prettier does not (yet, fcf. | ||
| # https://github.com/prettier/prettier/issues/15206) have an official | ||
| # docker image. | ||
| # https://hub.docker.com/r/jauderho/prettier is good candidate (cf. https://hub.docker.com/search?q=prettier&sort=updated_at&order=desc) | ||
| image: jauderho/prettier | ||
| profiles: | ||
| - dev | ||
| volumes: | ||
| - ./:/work | ||
|
|
Contributor
There was a problem hiding this comment.
It may be a good idea to move this to the end of the file, i.e. after “the real” project services, to make it clear that these services are “only” used for code checks, e.g.
…
memcached:
…
# Code checks tools
markdownlint:
…
…
rimi-itk
approved these changes
Jun 25, 2025
Contributor
rimi-itk
left a comment
rimi-itk
left a comment
There was a problem hiding this comment.
Approved with a comment: https://github.com/itk-dev/devops_itkdev-docker/pull/111/files#r2166503676
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add markdown lint and prettier services to all templates