Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't run image building in PR's branches #60

Closed
yelizariev opened this issue Mar 20, 2020 · 0 comments · Fixed by #65
Closed

Don't run image building in PR's branches #60

yelizariev opened this issue Mar 20, 2020 · 0 comments · Fixed by #65

Comments

@yelizariev
Copy link
Contributor

yelizariev commented Mar 20, 2020 •
edited

In private repositories pull requests should not be forked. That is a developer creates a temporary branch for this. Such a branch doesn't need own docker images. So, we need to disable the workflow for such cases.

On the other hand, there is a case when new temporary branch is created to send PRs there. In that case we need the docker images.

So, the specification could be as following:

make images only for main branches (10.0, 11.0, etc.) and development branches (10.0-dev-<some-name>, 11.0-dev-<another-name>
yelizariev added a commit to yelizariev/itpp-runbot that referenced this issue Mar 24, 2020
@yelizariev
skip image building in PR's branches
f2acd11 
closes itpp-labs#60
@yelizariev yelizariev mentioned this issue Mar 24, 2020
Merged
yelizariev added a commit to yelizariev/itpp-runbot that referenced this issue Mar 24, 2020
@yelizariev
skip image building in PR's branches
d8e9a64 
closes itpp-labs#60
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

skip image building in PR's branches yelizariev/itpp-runbot
1 participant
@yelizariev