Skip to content

Conversation

@itsdevdom
Copy link
Owner

@itsdevdom itsdevdom commented Jun 28, 2018

  • Upgrade to Angular 6 and RxJS 6, plus update other dependencies
  • Fix breaking changes (mostly RxJS imports)
  • Remove unused imports
  • Update and simplify webpack config (upgrade to Webpack 4, remove dll stuff and other plugins)
  • Update jest config (verbose, ignore dist folder)
  • Replace custom typings file with web-animations-js typings

Closes #82.
BREAKING CHANGE: The upgrade to Angular 6 breaks compatibility with Angular 5.

@itsdevdom itsdevdom changed the title feat(*): Upgrade to Angular 6, fix breaking changes [WIP] feat(*): Upgrade to Angular 6, fix breaking changes Jun 28, 2018
@itsdevdom itsdevdom changed the title [WIP] feat(*): Upgrade to Angular 6, fix breaking changes [BLOCKED] feat(*): Upgrade to Angular 6, fix breaking changes Jun 28, 2018
@itsdevdom
Copy link
Owner Author

Will superseed #80.

@codecov
Copy link

codecov bot commented Jun 28, 2018

Codecov Report

Merging #83 into develop will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop      #83   +/-   ##
========================================
  Coverage    99.13%   99.13%           
========================================
  Files           14       14           
  Lines          460      460           
  Branches        79       79           
========================================
  Hits           456      456           
  Misses           4        4
Impacted Files Coverage Δ
...lib/src/components/notifier-container.component.ts 97.64% <ø> (ø) ⬆️
src/lib/src/services/notifier-queue.service.ts 100% <100%> (ø) ⬆️
src/lib/src/services/notifier.service.ts 100% <100%> (ø) ⬆️
...lib/src/animation-presets/fade.animation-preset.ts 100% <100%> (ø) ⬆️
jest.setup.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b8bc7f...1309102. Read the comment docs.

@itsdevdom itsdevdom changed the title [BLOCKED] feat(*): Upgrade to Angular 6, fix breaking changes feat(*): Upgrade to Angular 6, fix breaking changes Jul 4, 2018
@itsdevdom itsdevdom merged commit aae723d into develop Jul 4, 2018
@itsdevdom itsdevdom deleted the feature/angular6-support branch July 4, 2018 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants