eval notes_off logic on every frame tick #10
Merged
Conversation
|
Sorry that some of my vim config cleaned up some whitespace, etc, automatically. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
See original comment on Lines here.
My understanding of the note & midi code is that we would want to evaluate whether or not a note should be "turned off" every tick, as opposed to when a midi OP is banged. Without this change, we effectively never send a
note offmessage to midi, and thelengthparameter doesn't do anything.With this change
lengthis respected and thenote offmessage is sent to midi after the appropriate number of frames have passed.