Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eval notes_off logic on every frame tick #10

Conversation

@robbiecloset
Copy link
Contributor

@robbiecloset robbiecloset commented Jul 19, 2019

See original comment on Lines here.

My understanding of the note & midi code is that we would want to evaluate whether or not a note should be "turned off" every tick, as opposed to when a midi OP is banged. Without this change, we effectively never send a note off message to midi, and the length parameter doesn't do anything.

With this change length is respected and the note off message is sent to midi after the appropriate number of frames have passed.

@robbiecloset
Copy link
Contributor Author

@robbiecloset robbiecloset commented Jul 19, 2019

Sorry that some of my vim config cleaned up some whitespace, etc, automatically.

@itsyourbedtime itsyourbedtime merged commit 407814c into itsyourbedtime:master Aug 5, 2019
@robbiecloset robbiecloset deleted the robbiecloset:robbiecloset/midi-notes-off branch Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants