Skip to content

Commit 5d68a57

Browse files
authored
Added procps to alpine image to resolve autopause compatibility (#1361)
1 parent 3886bca commit 5d68a57

File tree

4 files changed

+23
-20
lines changed

4 files changed

+23
-20
lines changed

.github/workflows/build-multiarch.yml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -97,11 +97,6 @@ jobs:
9797
username: ${{ secrets.DOCKER_USER }}
9898
password: ${{ secrets.DOCKER_PASSWORD }}
9999

100-
- name: Calculate build files revision
101-
id: build-files
102-
run: |
103-
echo "::set-output name=REV::$(git log -1 --format=%H build)"
104-
105100
- name: Build for test
106101
uses: docker/build-push-action@v2.9.0
107102
with:
@@ -114,7 +109,6 @@ jobs:
114109
push: false
115110
build-args: |
116111
BASE_IMAGE=${{ matrix.baseImage }}
117-
BUILD_FILES_REV=${{ steps.build-files.outputs.REV }}
118112
cache-from: type=gha,scope=${{ matrix.variant }}
119113
# no cache-to to avoid cross-cache update from next build step
120114

README.md

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -287,16 +287,17 @@ the server jar remain in the `/data` directory. It is safe to remove those._
287287

288288
When using the image `itzg:/minecraft-server` without a tag, the `latest` image tag is implied from the table below. To use a different version of Java, please use an alternate tag to run your Minecraft server container.
289289

290-
| Tag name | Java version | Linux | JVM Type | Architecture |
291-
| -------------- | -------------|--------|----------|-------------------|
292-
| latest | 17 | Debian | Hotspot | amd64,arm64,armv7 |
293-
| java8 | 8 | Alpine | Hotspot | amd64 |
290+
| Tag name | Java version | Linux | JVM Type | Architecture |
291+
|-----------------|-------------|--------|----------|-------------------|
292+
| latest | 17 | Debian | Hotspot | amd64,arm64,armv7 |
293+
| java8 | 8 | Alpine | Hotspot | amd64 |
294294
| java8-multiarch | 8 | Debian | Hotspot | amd64,arm64,armv7 |
295-
| java8-openj9 | 8 | Debian | OpenJ9 | amd64 |
296-
| java11 | 11 | Debian | Hotspot | amd64,arm64,armv7 |
297-
| java11-openj9 | 11 | Debian | OpenJ9 | amd64 |
298-
| java17 | 17 | Ubuntu | Hotspot | amd64,arm64,armv7 |
299-
| java17-openj9 | 17 | Debian | OpenJ9 | amd64 |
295+
| java8-openj9 | 8 | Debian | OpenJ9 | amd64 |
296+
| java11 | 11 | Debian | Hotspot | amd64,arm64,armv7 |
297+
| java11-openj9 | 11 | Debian | OpenJ9 | amd64 |
298+
| java17 | 17 | Ubuntu | Hotspot | amd64,arm64,armv7 |
299+
| java17-openj9 | 17 | Debian | OpenJ9 | amd64 |
300+
| java17-alpine | 17 | Alpine | Hotspot | amd64 |
300301

301302
For example, to use Java version 8 on any supported architecture:
302303

build/alpine/install-packages.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ apk add --no-cache -U \
1010
su-exec \
1111
coreutils \
1212
findutils \
13+
procps \
1314
shadow \
1415
bash \
1516
curl iputils \

tests/setuponlytests/test.sh

Lines changed: 12 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,16 @@ IFS=$'\n\t'
55
# go to script root directory
66
cd "$(dirname "$0")" || exit 1
77

8+
outputContainerLog() {
9+
logs=${1?}
10+
11+
echo "${folder} test scenario FAILED"
12+
echo ":::::::::::: LOGS ::::::::::::::::
13+
$logs
14+
::::::::::::::::::::::::::::::::::
15+
"
16+
}
17+
818
# tests that only run the setup files for things like downloads and configuration.
919
setupOnlyMinecraftTest(){
1020
folder=$1
@@ -23,15 +33,12 @@ setupOnlyMinecraftTest(){
2333
fi
2434

2535
if ! logs=$(docker-compose run mc 2>&1); then
26-
echo "${folder} test scenario FAILED"
27-
echo ":::::::::::: LOGS ::::::::::::::::
28-
$logs
29-
::::::::::::::::::::::::::::::::::
30-
"
36+
outputContainerLog "$logs"
3137
result=1
3238
elif [ -f verify.sh ]; then
3339
if ! docker run --rm --entrypoint bash -v "${PWD}/data":/data -v "${PWD}/verify.sh":/verify "${IMAGE_TO_TEST:-itzg/minecraft-server}" -e /verify; then
3440
echo "${folder} verify FAILED"
41+
outputContainerLog "$logs"
3542
result=1
3643
else
3744
echo "${folder} verify PASS"

0 commit comments

Comments
 (0)