-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
added Loliserver support #1483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added Loliserver support #1483
Conversation
|
Also adding a "setup only" test like this would be great: https://github.com/itzg/docker-minecraft-server/tree/master/tests/setuponlytests/pufferfish |
1c610f8 to
0b3cc9e
Compare
|
from my side it should be completed. |
|
Sorry for the delay in merging this. |
|
Looks like I'll need to remove the test since their site certificates are not fully legit: https://github.com/itzg/docker-minecraft-server/runs/6149493187?check_suite_focus=true#step:8:63 End users will probably run into this too, but that's what the disclaimer is for. |
|
Looks like this server isn't a thing anymore. The GitHub page, as well as the JAR download seem to be gone. |
|
Yep, zero repos. I was worried about the longevity of that one. A PR to remove support would be great. |
|
It moved to this repo here https://github.com/Luohuayu/CatServer with different branches for the versions. |
This PR adds support for the more recent hybrid server type LoliServer.
I am not very happy with how releases or updates are handled.
Built jars are just available on a jenkins server which the
lastSuccessfulBuildgetscurled and used.In advance iam not sure if all necessary changes are made so i would be thankful for a review/test.