Skip to content

Conversation

@Sylensky
Copy link
Contributor

This PR adds support for the more recent hybrid server type LoliServer.
I am not very happy with how releases or updates are handled.
Built jars are just available on a jenkins server which the lastSuccessfulBuild gets curled and used.

In advance iam not sure if all necessary changes are made so i would be thankful for a review/test.

@itzg
Copy link
Owner

itzg commented Apr 20, 2022

Also adding a "setup only" test like this would be great:

https://github.com/itzg/docker-minecraft-server/tree/master/tests/setuponlytests/pufferfish

@Sylensky Sylensky force-pushed the feature/loliserver branch from 1c610f8 to 0b3cc9e Compare April 20, 2022 19:34
@Sylensky
Copy link
Contributor Author

from my side it should be completed.

@itzg itzg merged commit 3e6ef1a into itzg:master Apr 24, 2022
@itzg
Copy link
Owner

itzg commented Apr 24, 2022

Sorry for the delay in merging this.

@itzg
Copy link
Owner

itzg commented Apr 25, 2022

Looks like I'll need to remove the test since their site certificates are not fully legit:

https://github.com/itzg/docker-minecraft-server/runs/6149493187?check_suite_focus=true#step:8:63

End users will probably run into this too, but that's what the disclaimer is for.

@Scrumplex
Copy link

Looks like this server isn't a thing anymore. The GitHub page, as well as the JAR download seem to be gone.
See https://github.com/Loli-Server/LoliServer

@itzg
Copy link
Owner

itzg commented Jul 22, 2022

Yep, zero repos. I was worried about the longevity of that one.

A PR to remove support would be great.

@Sylensky
Copy link
Contributor Author

It moved to this repo here https://github.com/Luohuayu/CatServer with different branches for the versions.
Unfortunately i run currently low on time to create PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants