From 8cc8278dd8a96448e37ffc1a4e183fc048d95b55 Mon Sep 17 00:00:00 2001 From: Geoff Bourne Date: Tue, 13 Jun 2023 09:26:14 -0500 Subject: [PATCH 1/2] docs: updated development notes to use jwebserver --- docs/misc/contributing/development.md | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/docs/misc/contributing/development.md b/docs/misc/contributing/development.md index 184c0340d0b..dccbcf8a8ec 100644 --- a/docs/misc/contributing/development.md +++ b/docs/misc/contributing/development.md @@ -75,17 +75,15 @@ In the cloned copy of [`mc-image-helper`](https://github.com/itzg/mc-image-helpe ./gradlew distTar ``` -Assuming [http-server](https://www.npmjs.com/package/http-server) is installed globally, start a static web server using: +Assuming Java 18 or newer: ```shell -http-server ./build/distributions -p 8080 +jwebserver -d ./build/distributions -b 0.0.0.0 ``` -Note the port that was selected by http-server and pass the build arguments, such as: - ```shell --build-arg MC_HELPER_VERSION=1.8.1-SNAPSHOT \ ---build-arg MC_HELPER_BASE_URL=http://host.docker.internal:8080 +--build-arg MC_HELPER_BASE_URL=http://host.docker.internal:8000 ``` Now the image can be built like normal, and it will install mc-image-helper from the locally built copy. From 7e7e62143cdc22a1aee5c78baaa7d950c6306947 Mon Sep 17 00:00:00 2001 From: Geoff Bourne Date: Tue, 13 Jun 2023 09:29:22 -0500 Subject: [PATCH 2/2] Fixed directory --- docs/misc/contributing/development.md | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/docs/misc/contributing/development.md b/docs/misc/contributing/development.md index dccbcf8a8ec..43ec9e6e26f 100644 --- a/docs/misc/contributing/development.md +++ b/docs/misc/contributing/development.md @@ -75,15 +75,19 @@ In the cloned copy of [`mc-image-helper`](https://github.com/itzg/mc-image-helpe ./gradlew distTar ``` +!!! note + The distribution's version will be `0.0.0--SNAPSHOT` + Assuming Java 18 or newer: ```shell -jwebserver -d ./build/distributions -b 0.0.0.0 +cd build/distributions +jwebserver -b 0.0.0.0 -p 8008 ``` ```shell --build-arg MC_HELPER_VERSION=1.8.1-SNAPSHOT \ ---build-arg MC_HELPER_BASE_URL=http://host.docker.internal:8000 +--build-arg MC_HELPER_BASE_URL=http://host.docker.internal:8008 ``` Now the image can be built like normal, and it will install mc-image-helper from the locally built copy.