Skip to content

curseforge: ensure modpack-file listing is not out-dated #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 23, 2023
Merged

curseforge: ensure modpack-file listing is not out-dated #147

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
335a158
curseforge: ensure modpack-file listing is not out-dated
itzg Feb 23, 2023
fa908ce
fixed typo
itzg Feb 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/main/java/me/itzg/helpers/curseforge/CurseForgeInstaller.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,9 @@ private static CurseForgeFile resolveModpackFile(SharedFetch preparedFetch, UriB
) {
// NOTE latestFiles in mod is only one or two files, so retrieve the full list instead
final GetModFilesResponse resp = preparedFetch.fetch(
uriBuilder.resolve("/mods/{modId}/files", mod.getId())
// 'latest' parameter is not recognized by the API but rather used to force it not to return
// a cached listing
uriBuilder.resolve("/mods/{modId}/files?latest={ts}", mod.getId(), System.currentTimeMillis())
)
.toObject(GetModFilesResponse.class)
.execute();
Expand Down