From c15b5b53c37dafa6b70c3dc3272a9e600de14c7a Mon Sep 17 00:00:00 2001 From: Geoff Bourne Date: Wed, 30 Apr 2025 08:48:32 -0500 Subject: [PATCH 1/2] cf: include more detail with "No matching files found for mod" error --- .../java/me/itzg/helpers/curseforge/CurseForgeApiClient.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/main/java/me/itzg/helpers/curseforge/CurseForgeApiClient.java b/src/main/java/me/itzg/helpers/curseforge/CurseForgeApiClient.java index 0f13021f..9b26ca14 100644 --- a/src/main/java/me/itzg/helpers/curseforge/CurseForgeApiClient.java +++ b/src/main/java/me/itzg/helpers/curseforge/CurseForgeApiClient.java @@ -184,7 +184,9 @@ public CurseForgeFile resolveModpackFile( log.debug("No matching files trying fileMatcher={} against {}", fileMatcher, mod.getLatestFiles() ); - return new GenericException("No matching files found for mod"); + return new GenericException(String.format("No matching files found for mod with id=%s, name=%s using fileMatcher='%s'", + mod.getId(), mod.getName(), fileMatcher) + ); }); } From 10df1511207c24e66c18dc090d4f9ccf7674752b Mon Sep 17 00:00:00 2001 From: Geoff Bourne Date: Wed, 30 Apr 2025 08:56:52 -0500 Subject: [PATCH 2/2] Tweak log and exception message --- .../me/itzg/helpers/curseforge/CurseForgeApiClient.java | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/main/java/me/itzg/helpers/curseforge/CurseForgeApiClient.java b/src/main/java/me/itzg/helpers/curseforge/CurseForgeApiClient.java index 9b26ca14..acf067f9 100644 --- a/src/main/java/me/itzg/helpers/curseforge/CurseForgeApiClient.java +++ b/src/main/java/me/itzg/helpers/curseforge/CurseForgeApiClient.java @@ -181,11 +181,12 @@ public CurseForgeFile resolveModpackFile( (fileMatcher == null || file.getFileName().contains(fileMatcher))) .findFirst() .orElseThrow(() -> { - log.debug("No matching files trying fileMatcher={} against {}", fileMatcher, - mod.getLatestFiles() + log.debug("No matching files for mod id={} name={} trying fileMatcher={}, sample of latest files={}", + mod.getId(), mod.getName(), + fileMatcher, mod.getLatestFiles() ); - return new GenericException(String.format("No matching files found for mod with id=%s, name=%s using fileMatcher='%s'", - mod.getId(), mod.getName(), fileMatcher) + return new GenericException(String.format("No matching files found for mod '%s' (%d) using fileMatcher '%s'", + mod.getSlug(), mod.getId(), fileMatcher) ); }); }