feat(409): opt-out of auto-scaling per server (k8s) #454
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #409 and adds the possibility to selectively disable auto-scaling via annotations on Kubernetes.
Annotations:
mc-router.itzg.me/autoScaleUpfor controlling scale-upmc-router.itzg.me/autoScaleDownfor controller scale-downAs mentioned, it is currently only possible to opt-out of auto-scaling, as the configuration flags
--auto-scale-upand--auto-scale-downdecide whether or not the actual watcher service is being instantiated or not. However, the piece of logic I added should also work for opt-in if it is being called.I chose the annotations to work on
Servicerather thanStatefulSetbecause the service seems like the main abstraction for the server configuration and the stateful-set is only the backend.@itzg unfortunately I had to migrate the version of package
golang.ngrok.com/ngrokdown tov1.12.1because I was not able to build forv1.13.0. It was complaining that this rev does not exist anymore. I checked the Github repo and it does indeed not exist.