Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Switch to innertube for the captions - captions do not work on public instances #2567

Closed
unixfox opened this issue Nov 6, 2021 · 9 comments · Fixed by #4001
Labels
bounty bounty:20$ enhancement Improvement of an existing feature

Comments

@unixfox
Copy link
Member

unixfox commented Nov 6, 2021

Is your enhancement request related to a problem? Please describe.
The current way of retrieving the captions is rate limited by google and captions doesn't work on popular instances.

Describe the solution you'd like
We should switch to the innertube for retrieving the captions because on innertube there is no rate limit (for the moment).

Describe alternatives you've considered

Install and use Invidious locally or switch to a less popular instances from https://instances.invidious.io

Additional context
Related to #2519 and #2565

@unixfox unixfox added the enhancement Improvement of an existing feature label Nov 6, 2021
@syeopite
Copy link
Member

Possible solution #2564

@TheFrenchGhosty
Copy link
Member

TheFrenchGhosty commented Nov 17, 2021

A 20$ bounty has been added to this issue.

Anyone opening a PR fixing this issue, will receive 20$ (in BTC) from the Invidious project.

More details: #1898

@rottenwheel
Copy link

rottenwheel commented Feb 13, 2022

I can personally offer $80 worth of XMR on top of the $20 worth of BTC from the Invidious project, to be claimed by whoever opens a PR switching to innertube for captions to work.

Please ping me here, or via Matrix should there be any news or comments; will try to keep an eye open regardless.

@unixfox
Copy link
Member Author

unixfox commented Sep 17, 2022

About https://github.com/iv-org/invidious/blob/master/src/invidious/routes/api/v1/videos.cr#L34

timedtext API does now provide links for auto-generated captions. Could this replace the current implement of getting the captions?

@tuxayo
Copy link

tuxayo commented Oct 30, 2022

How does newpipe does it? Is it because it does it directly so it's not rate limited at the expense of a risk of user tracking?

Due to the elapsed time, is this less work-demanding solution worth considering as an alternative? : if proxy is disabled, then do the request for subtitles directly from user's browser.

@tuxayo
Copy link

tuxayo commented Oct 30, 2022

request: rename the issue "Captions don't work on popular instances" or something like that so people can more simply find it. And it's not an enhancement, it's a bug.

@unixfox
Copy link
Member Author

unixfox commented Oct 30, 2022

How does newpipe does it? Is it because it does it directly so it's not rate limited at the expense of a risk of user tracking?

Whatever how newpipe does it, newpipe send the request from the IP address of the user so there no rate limit applied as a single user will never do as many requests as a Invidious instance.

@unixfox unixfox changed the title [Enhancement] Switch to innertube for the captions [Enhancement] Switch to innertube for the captions - captions do not work on public instances Apr 14, 2023
@iv-org iv-org deleted a comment Jul 27, 2023
@RadoslavL
Copy link
Contributor

@rottenwheel syeopite seems to have solved the issue. They created a PR that is now merged.

@syeopite
Copy link
Member

syeopite commented Sep 20, 2023

The only thing that's left to do is to document the fix. Instances will have to enable the use_innertube_for_captions option within the config to bring back caption capabilities.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bounty bounty:20$ enhancement Improvement of an existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants