Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add annotation player #303

Merged
merged 2 commits into from May 1, 2019
Merged

Add annotation player #303

merged 2 commits into from May 1, 2019

Conversation

@glmdgrielson
Copy link

@glmdgrielson glmdgrielson commented Jan 20, 2019

This addresses issue #110. Yay for adding annotations back!

This should do until the archive system gets revamped.

@omarroth
Copy link
Contributor

@omarroth omarroth commented Jan 21, 2019

Great!

I'll plan on adding an updated version of videojs-youtube-annotations.js before merging, since there's quite a few features missing that are included in the extension it's based on.

The /api/v1/annotations/:id is temporary and will also change once everything has been uploaded to the Internet Archive.

https://dev.invidio.us is now pulling from this branch, so if annotations for a video are available from the temporary API, you should be able to view them.

@glmdgrielson
Copy link
Author

@glmdgrielson glmdgrielson commented Jan 21, 2019

So the video issue gas been resolved? What about the 4.3 one?

@omarroth
Copy link
Contributor

@omarroth omarroth commented Jan 21, 2019

I expect that will be fixed in afrmtbl/annotationlib.

@omarroth omarroth force-pushed the annotations branch 3 times, most recently from ee87467 to 7deaf29 Jan 29, 2019
@glmdgrielson
Copy link
Author

@glmdgrielson glmdgrielson commented Jan 29, 2019

Why aren't we using the <%= video.id %> here?

@omarroth
Copy link
Contributor

@omarroth omarroth commented Jan 30, 2019

<%= video.id %> refers to the current video. For annotations, we want to find the video that's being linked, so we use the video ID included in the search parameters.

@omarroth omarroth force-pushed the annotations branch 4 times, most recently from be686da to cf9c9c7 Jan 31, 2019
@AgentGrady
Copy link

@AgentGrady AgentGrady commented Feb 5, 2019

Several videos that had working annotations on invidious just a few days ago have suddenly stopped working. Why is this?

@omarroth
Copy link
Contributor

@omarroth omarroth commented Feb 5, 2019

Mind posting the output of the console or linking to an example?

@omarroth omarroth force-pushed the annotations branch 10 times, most recently from 491e26f to c591f26 Apr 19, 2019
@omarroth omarroth force-pushed the annotations branch 9 times, most recently from 0a275c1 to 0ff30e5 Apr 25, 2019
@omarroth omarroth force-pushed the annotations branch 2 times, most recently from 002cd3d to 68c9878 Apr 29, 2019
glmdgrielson and others added 2 commits May 1, 2019
This addresses issue iv-org#110 from master. Yay for adding annotations back!
@AgentGrady
Copy link

@AgentGrady AgentGrady commented Nov 20, 2019

@github-actions
Copy link

@github-actions github-actions bot commented Jun 10, 2021

This pull request has been automatically locked since there has not been any activity in it in the last 30 days. If you want to tell us about needed or wanted changes or if problems related to this code are discovered, feel free to open an issue or a new pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants