Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Community: Minor HTML/CSS fixes #3783

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

SamantazFox
Copy link
Member

Some minor HTML and CSS fixes:

  • Limit width of comments to about 800 CSS pixels
  • Make embedded videos look better
  • Remove some inline style
  • Wrap the "footer" (publication date + link + likes) in <p></p> to space it out from the content

result:
image

@SamantazFox SamantazFox requested a review from a team as a code owner May 6, 2023 18:35
@SamantazFox SamantazFox requested review from unixfox and removed request for a team May 6, 2023 18:35
@SamantazFox
Copy link
Member Author

Deployed at https://test.invidious.io

@SamantazFox SamantazFox added in-testing This feature has been deployed and is being tested need-code-review A crystal developper need to check if the code is correct. labels May 6, 2023
@ChunkyProgrammer
Copy link
Contributor

ChunkyProgrammer commented May 7, 2023

Edit: ignore this, this is not caused by the pr!

Tested on phone (didn't do a full test), i have to scroll down quite a bit to see the error message for videos with errors:

What I initially see:
Screenshots_2023-05-07-10-18-31

What i see after scrolling:
Screenshots_2023-05-07-10-18-53

This is not related to the PR but is there a reason why embed videos are used in the community page? It's different from how videos are displayed elsewhere.
Ex:
Screenshots_2023-05-07-10-21-29

@SamantazFox
Copy link
Member Author

@ChunkyProgrammer Yeah, this is not related to this PR. However, the embed video page shouldn't show the whole webpage if the content is unavailable (in this case, members-only video). And the Iframe should probably be bigger anyway!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in-testing This feature has been deployed and is being tested need-code-review A crystal developper need to check if the code is correct.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants