Permalink
Commits on Sep 10, 2013
  1. Merge pull request #535 from dotta/wip/repeat-flaky-test

    dotta committed Sep 10, 2013
    Retry `HyperlinkDetectorTests.test1000656` flaky test
  2. Merge pull request #533 from dotta/issue/source-attachments-for-sbt-p…

    dotta committed Sep 10, 2013
    …r-482
    
    source attachments for sbt
  3. Merge pull request #529 from dotta/issue/launch-config-does-not-find-…

    dotta committed Sep 10, 2013
    …main-in-jar-1001878
    
    Issue/launch config does not find main in jar 1001878
  4. Adding organisation information in the POM to reduce duplication

    dotta committed Sep 9, 2013
    In fact, the default value for Bundle-Vendor is ${pom.organization.name}
  5. Deleted unneeded import-package clauses in toolchain MANIFESTs

    dotta committed Sep 9, 2013
    The maven build does no longer spits out warnings for unused package imports in MANIFESTs.
  6. No reason for putting the manifest in the ${basedir}

    dotta committed Sep 9, 2013
    The one single reason for doing it is to allow to import in the workspace the
    `sbt.full.library` project, so that it can be correctly consumed by the
    dependent projects (e.g., the `core project). However, given we practically
    never had to do so in the past 6 months, it feels reasonable to remove the
    flexiblity in the name of a cleaner build. In case you will need to import he
    `sbt.full.library` project in Eclipse at any point, just create the required
    .classpath and .project, and copy/paste in the project's root the META-INF
    folder generated by the build (look in the target/ folder). Make  sure to do
    the same for the `sbt.compiler.interface` project.
  7. Added a source bundle for the sbt library.

    dotta committed Aug 13, 2013
    This commit allows debugging, hyperlinking, etc. towards
    sbt sources. Useful when working on the Sbt builder.
    
    * create a source bundle for the sbt library. I needed to
      inline the contents of sbt jars in order to get Eclipse
      to correctly associate sources with classfiles
    
    * created a new compiler.interface bundle, only for the
      compiler interface, together with the matching
      `compiler.interface.sources` bundle. Sbt requires this to
      be a separate jar and there was no way to build a single sbt
      bundle with only some of the dependencies inlined.
    
    A similar approach could be used for the Scala library/compiler
    bundles, but we should investigate the possibility of having the
    Scala team publish source bundles too (Re #1001889).
    
    (this was originally a commit from @dragos, which I have adapted
    based on the comments in scala-ide#482)
    
    Fixes #1001888
  8. Dumbed down `MainClassVerifier` to only check class vs module mismatch

    dotta committed Sep 10, 2013
    Experience taught us that `MainClassVerifier` is trying to be too smart, and
    often prevents user from launching perfectly fine Scala launch configurations.
    The last manifestation was that it would prevent users from launching a main if
    defined in a JAR.
    
    The matter was discussed with the team and the agreed descision is to reduce
    the scope of the `MainClassVerifier` to only prevent users from:
    
    * launching a Scala application if the project contains build errors, and
    * provide feedback when trying to launch a Scala `class`, instead of a `object`
    
    Consequently, we no longer prevent users from launching a Scala application
    that is incorrectly configured (i.e., the classfile doesn't exist). The
    consequence is that a `NoClassFoundException` will be reported to the user in
    this case, which actually matches the behavior in the Eclipse Java support.
    
    Let's dive into the details and describe what are the extent of the changes
    carried out by this commit:
    
    * Check for build errors is performed only if the a classfile for the
      `mainTypeName` provided in the Run config can't be found. Hence, if the
      classfile exist, this allows you to run your application even if there are
      errors in the project.
    
    * `ScalaLaunchDelegate.finalLaunchCheck` does not longer call `super`. This is
      to avoid the Java Eclipse prompt is displayed. Instead, the `UIReporter` is
      called, and I've improved it to be a standard platform dialog. The improved
      dialog also allows users to by-pass the check.
    
    * This patch consciously breaks source compatibility (because I removed the
      `MainClassVerifier` constructor, and deleted the `ErrorReporter` trait).
      I could re-introduce them and use deprecation, but it doesn't seem worth the
      effort (and none has complained about this change during the review process).
    
    backport to release/scala-ide-3.0.x
    
    Re #1001882
    Fixes #1001878
Commits on Sep 9, 2013
  1. Retry `HyperlinkDetectorTests.test1000656` flaky test

    dotta committed Sep 9, 2013
    Re #1001880
  2. Merge pull request #532 from dotta/wip/split-readme-contributing

    dotta committed Sep 9, 2013
    Moved contributing section from README to CONTRIBUTING
  3. Moved contributing section from README to CONTRIBUTING

    dotta committed Sep 8, 2013
    This is the preferred standard for git repository hosted on GitHub (see
    https://github.com/blog/1184-contributing-guidelines)
Commits on Sep 6, 2013
  1. Merge pull request #531 from skyluc/issue/continuations-not-enabled-o…

    skyluc committed Sep 6, 2013
    …n-211
    
    Updates continuations option tests for 2.11
Commits on Sep 5, 2013
  1. Merge pull request #527 from sschaef/t-resolve-2.11-error

    huitseeker committed Sep 5, 2013
    Resolves a compilation error reported with 2.11
  2. Resolves a compilation error reported with 2.11

    sschaef committed Sep 4, 2013
    In 2.11 octal escape literals are now unsupported
    
    For more information about the change see SI-7292
  3. Updates continuations option tests for 2.11

    skyluc committed Sep 5, 2013
    In Scala 2.11, the continuation plugin is no more enabled by default when
    available.
    Two main changes:
    - forces enable the continuation plugin when running the tests on Scala 2.11
    - modifies the tests to use the project specific preferences, to avoid side effects
    of the configuration changes needed for the tests.
  4. Merge pull request #528 from dotta/issue/rollback-additional-pc-synch…

    dotta committed Sep 5, 2013
    …ronization-because-of-deadlock-at-startup-1001875
    
    Revert "Sync 'isDefined' in presentation compiler cache."
  5. Revert "Sync 'isDefined' in presentation compiler cache."

    dotta committed Sep 5, 2013
    This reverts commit 3608a81.
    
    We need to revert this because of a possible deadlock at startup between the PC
    and the classpath resolution. More information on the related ticket (#1001875).
    
    backport to release/scala-ide-3.0.x
    
    Review by @dragos
    
    Re #1001880
    Fixes #1001875
Commits on Sep 4, 2013
  1. Merge pull request #518 from dragos/issue/fix-derived-output-folders-…

    dotta committed Sep 4, 2013
    …1000260
    
    Mark output folders as "Derived".
  2. Merge pull request #515 from huitseeker/pr/489

    huitseeker committed Sep 4, 2013
    ReplConsoleView multiline input + refactoring
  3. Adds missing super.dispose call

    huitseeker committed Aug 30, 2013
    Cosmetics
    
    Relax needlessly concrete members in Intermediate trait.
  4. ReplConsoleView multiline input + refactoring

    Jedd Haberstro committed with huitseeker Aug 8, 2013
    Multiline input field in the ReplConsoleView. The UI elements have also been factored out into a trait. To evaluate code/change history, CTRL must be held as well.
    
    CommandField keyboard events can now be overridden, too.
Commits on Sep 3, 2013
  1. Merge pull request #525 from huitseeker/issue/clean-up-tokenize-10018166

    huitseeker committed Sep 3, 2013
    cleaning up test after implementation of tokenize(str:String, ...)
  2. cleaning up test after implementation of tokenize(str:String, ...)

    huitseeker committed Sep 3, 2013
    Along with #521, #523, fixes #1001866
  3. Merge pull request #517 from dragos/issue/flaky-test-errors

    dragos committed Sep 3, 2013
    Tests may fail with an exception, we need to retry those too.
Commits on Sep 2, 2013
  1. Mark output folders as "Derived".

    dragos committed Sep 2, 2013
    Derived folders won't appear in "Open Resource", polluting
    names with classfiles.
    
    Fixes #1000260 (which regressed at some point in time).
  2. Merge pull request #511 from skyluc/issue/current-selected-thread-100…

    skyluc committed Sep 2, 2013
    …1585
    
    Uses new debug view selection support
  3. Uses new debug view selection support

    skyluc committed Aug 28, 2013
    In Eclipse 4.x, a new way to follow the current selection in the debug view was implemented,
    as debug specific support.
    The old way was slightly broken, and was no more working for selection changes not triggered
    by the user. A temporary fix was implemented in Scala 3.0.x, to support Eclipse 3.x and 4.x.
    This commit replace the old code and the fix by a solution using the new support.
    
    Fixes #1001585
    Need to be backported in 3.0.x-juno.
Commits on Aug 30, 2013
  1. Merge pull request #512 from huitseeker/sbt-update

    huitseeker committed Aug 30, 2013
    Update sbt version after 0.13.0 release
  2. Merge pull request #508 from huitseeker/undocumented-deprecate

    huitseeker committed Aug 30, 2013
    remove controversial & undocumented deprecation