Skip to content

Fix a bug that prevent vim-ipython to load from vim in console mode#1

Closed
tcheneau wants to merge 1 commit into
ivanov:masterfrom
tcheneau:master
Closed

Fix a bug that prevent vim-ipython to load from vim in console mode#1
tcheneau wants to merge 1 commit into
ivanov:masterfrom
tcheneau:master

Conversation

@tcheneau

@tcheneau tcheneau commented Aug 6, 2011

Copy link
Copy Markdown

If I am not wrong, (Console) Vim does not offer the balloons support. Hence, the plugin fails to load
in console mode (at the "set bexpr" instruction).

This small workaround loads the balloons only when Gvim is started.

(Console) Vim does not offer the balloons support. Hence, the plugin fails to load
in console mode. This small commit checks for the presence of the GUI.
@ivanov

ivanov commented Aug 6, 2011

Copy link
Copy Markdown
Owner

Thanks for the pull request. I saw this also in @nakamuray 's branch - but cannot reproduce the error locally, which i why I didn't merge yet. Can you tell me what the error is (and what version of vim)? My impression is that ballooneval and bexpr are ignored in console mode.

@tcheneau

tcheneau commented Aug 7, 2011

Copy link
Copy Markdown
Author

I don't know if it can be reproduced on every installation, but on Fedora and Gentoo, both the :set ballooneval and :set bexpr commands return a E518: Unknown option error when set within vim. Gvim does not share this behavior.

Vim version on my Gentoo is 7.3.189 (I do not have access to the Fedora right now).

Please let me know if you need more details on my test systems or if I can help in any other ways.

@nakamuray

Copy link
Copy Markdown

Both options are available only if vim is built with balloon_eval feature.

So, it depend on how your vim is compiled.

@tcheneau

tcheneau commented Aug 7, 2011

Copy link
Copy Markdown
Author

Then, the test should be replaced by if has("ballon_eval") ?

@ivanov ivanov closed this in b66b480 Aug 9, 2011
@ivanov

ivanov commented Aug 9, 2011

Copy link
Copy Markdown
Owner

thank you both for the help!

scholi pushed a commit to scholi/vim-ipython that referenced this pull request Jun 18, 2018
Made cells compatible with IPython notebooks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants