Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Erratas in the article: Functional Reactive Programming, Refactored (Haskell Symposium 2016) #106

Closed
chriz-zeller opened this issue Jun 2, 2018 · 3 comments

Comments

@chriz-zeller
Copy link

Hi,

while I was reading parts of this article:

Functional Reactive Programming, Refactored
Haskell 2016 Proceedings of the 9th International Symposium on Haskell
Pages 33-44

I found two points that confused me and I think that there is something wrong with it:

In Section 4.1 Reader

There is a parenthesis mismatch in

  embed (    runReaderS testMSF (GameSettings 0 3)
         &&& runReaderS testMSF (GameSettings 0 2))
        (repeat 5 ()))

I guess it should be:

  embed (    runReaderS testMSF (GameSettings 0 3)
         &&& runReaderS testMSF (GameSettings 0 2)
        )
        (
         repeat 5 ()
        )

The result of this function is stated as:

[ ((1, False), (1, False)), ((2, False), (2, False))
, ((3, False), (3, True )), ((4, True ), (4, True ))
, ((5, True ), (5, True ))]

but I think it should be ((2, False), (2, True)):

[ ((1, False), (1, False)), ((2, False), (2, True ))
, ((3, False), (3, True )), ((4, True ), (4, True ))
, ((5, True ), (5, True ))]

I hope this is the right place to mention these issues.

Best,
Christina

@chriz-zeller chriz-zeller changed the title Erratas in the article: Functional Reactive Programming, Refactores (Haskell Symposium 2016) Erratas in the article: Functional Reactive Programming, Refactored (Haskell Symposium 2016) Jun 2, 2018
@ivanperez-keera
Copy link
Owner

This is true, and it should probably be listed officially somewhere. I link to the article on my website, so there could be a link to an errata there. @turion do you have the article listed on your website or something?

@turion
Copy link
Contributor

turion commented Jun 18, 2018

True. I'll link to this issue for errata for the time being.

@ivanperez-keera
Copy link
Owner

Acknowledged. I'm linking to the paper from my website.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants