Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render emojis in project descriptions #68

merged 1 commit into from Oct 12, 2017

Render emojis in project descriptions #68

merged 1 commit into from Oct 12, 2017


Copy link

@c-w c-w commented Oct 12, 2017

This is an alternative to #67 (which was opened while I was implementing this PR). This approach uses the React component provided by react-emoji-render to render the emojis in the project descriptions.

Using a component over an inline function has the advantage that it's slightly more readable/declarative and also avoids re-renders of the component on every cycle since React can figure out that the props of the Emoji component haven't changed since the last render.

Here is an example of a project description being rendered with an emoji:


Resolves #63

@ivanseed ivanseed merged commit 660aabf into ivanseed:master Oct 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants