Render emojis in project descriptions#68
Merged
ivanseed merged 1 commit intoivanseed:masterfrom Oct 12, 2017
c-w:master
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an alternative to #67 (which was opened while I was implementing this PR). This approach uses the React component provided by react-emoji-render to render the emojis in the project descriptions.
Using a component over an inline function has the advantage that it's slightly more readable/declarative and also avoids re-renders of the component on every cycle since React can figure out that the props of the Emoji component haven't changed since the last render.
Here is an example of a project description being rendered with an emoji:
Resolves #63