From a9da95400c9f8ef0c218572c74dfa7ec36d517fe Mon Sep 17 00:00:00 2001
From: ivaquero <msaintms@outlook.com>
Date: Fri, 11 Aug 2023 14:20:15 +0800
Subject: [PATCH] =?UTF-8?q?chore:=20=F0=9F=92=84=20update=20styles=20based?=
 =?UTF-8?q?=20on=20shellcheck?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 install.sh  |  2 +-
 oxidizer.sh | 12 ++++++------
 2 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/install.sh b/install.sh
index 73206895..4c60c4fa 100644
--- a/install.sh
+++ b/install.sh
@@ -45,7 +45,7 @@ brew tap "homebrew/bundle"
 
 printf "📦 Installing essential Oxidizer toolchains...\n"
 
-for pkg in $(cat ${OXIDIZER}/defaults/Brewfile.txt); do
+cat ${OXIDIZER}/defaults/Brewfile.txt | while read pkg; do
     case $pkg in
     ripgrep)
         cmd='rg'
diff --git a/oxidizer.sh b/oxidizer.sh
index 5e3942d3..aa4c852f 100644
--- a/oxidizer.sh
+++ b/oxidizer.sh
@@ -132,7 +132,7 @@ ipall() {
 }
 
 iiox() {
-    print "Installing Required packages...\n"
+    printf "Installing Required packages...\n"
     for pkg in $(cat ${OXIDIZER}/defaults/Brewfile.txt); do
         case $pkg in
         ripgrep)
@@ -160,15 +160,15 @@ iiox() {
 # update Oxidizer
 upox() {
     cd ${OXIDIZER} || exit
-    print "Updating Oxidizer...\n"
+    printf "Updating Oxidizer...\n"
     git fetch origin master
     git reset --hard origin/master
 
     if [ ! -d ${OXIDIZER}/oxplugins-zsh ]; then
-        print "\n\nCloning Oxidizer Plugins...\n"
+        printf "\n\nCloning Oxidizer Plugins...\n"
         git clone --depth=1 https://github.com/ivaquero/oxplugins-zsh.git
     else
-        print "\n\nUpdating Oxidizer Plugins...\n"
+        printf "\n\nUpdating Oxidizer Plugins...\n"
         cd ${OXIDIZER}/oxplugins-zsh || exit
         git fetch origin main
         git reset --hard origin/main
@@ -177,8 +177,8 @@ upox() {
     cd ${OXIDIZER} || exit
     ox_change=$(git diff defaults.sh)
     if [ -n "$ox_change" ]; then
-        print "\n\nDefaults changed, don't forget to update your custom.sh accordingly...\n"
-        print "Compare the difference using 'edf oxd'"
+        printf "\n\nDefaults changed, don't forget to update your custom.sh accordingly...\n"
+        printf "Compare the difference using 'edf oxd'"
     fi
     cd ${HOME} || exit
 }