-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added swaggo operation ID & renamed handlers #79
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍🏻
branch.go
Outdated
@@ -19,28 +19,30 @@ type branchModule struct { | |||
func (m branchModule) Register(g *gin.RouterGroup) { | |||
branches := g.Group("/branches") | |||
{ | |||
branches.GET("", m.GetBranchesHandler) | |||
branches.PUT("", m.PutBranchesHandler) | |||
branches.GET("", m.getBrancheListHandler) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/getBrancheListHandler/getBranchListHandler/
Wouldn't this potentially count as a MAJOR version bump, since the function names when generating rest clients over at wharf-web will change? Or is it decoupled in a way that makes it not really count? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
The endpoints stay the same. So older versions will still work with the new version. |
Co-authored-by: Alexamakans <79503481+Alexamakans@users.noreply.github.com>
CHANGELOG.md
file, according to docs:https://iver-wharf.github.io/#/development/changelogs/writing-changelogs
Summary
// @id
comment field, which adds Swagger operation IDs to the endpoints.Motivation
Closes #67