Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change RxJS subscribe usage for RxJS v8 #62

Closed
applejag opened this issue Sep 8, 2021 · 0 comments · Fixed by #77
Closed

Change RxJS subscribe usage for RxJS v8 #62

applejag opened this issue Sep 8, 2021 · 0 comments · Fixed by #77
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@applejag
Copy link
Contributor

applejag commented Sep 8, 2021

Deprecation of method signature for subscribe(), need to use object with keys next, error, and complete instead of 3 separate args: https://rxjs.dev/deprecations/subscribe-arguments

BeforeAfter
of([1,2,3]).subscribe(
    (v) => console.log(v),
    (e) => console.error(e),
    () => console.info('complete'),
)
of([1,2,3]).subscribe({
    next: (v) => console.log(v),
    error: (e) => console.error(e),
    complete: () => console.info('complete'),
})

This work was started in #54 (comment) but needs to be applied throughout the entire repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants