{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":675839872,"defaultBranch":"master","name":"watchdog","ownerLogin":"ivg","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2023-08-07T21:15:30.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/2336698?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1691675545.0","currentOid":""},"activityList":{"items":[{"before":"b6d791f4f4cb46ed2e67c264b0054500ea722af5","after":"c7df2bf3e8eb68bef4b8b0e4be13e96a28dfbeaa","ref":"refs/heads/fixes-debouncer","pushedAt":"2024-07-28T14:22:52.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"BoboTiG","name":"Mickaël Schoentgen","path":"/BoboTiG","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2033598?s=80&v=4"},"commit":{"message":"Update event_debouncer.py","shortMessageHtmlLink":"Update event_debouncer.py"}},{"before":"66863ab60b2e7f6a5edfc366e7428b1ea558ae2e","after":"b6d791f4f4cb46ed2e67c264b0054500ea722af5","ref":"refs/heads/fixes-debouncer","pushedAt":"2024-07-28T14:15:34.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"BoboTiG","name":"Mickaël Schoentgen","path":"/BoboTiG","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2033598?s=80&v=4"},"commit":{"message":"Update test_0_watchmedo.py","shortMessageHtmlLink":"Update test_0_watchmedo.py"}},{"before":"8b1726c71f29315a3d2ab88dcebedbaa9f0565d5","after":"66863ab60b2e7f6a5edfc366e7428b1ea558ae2e","ref":"refs/heads/fixes-debouncer","pushedAt":"2024-07-28T14:10:16.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"BoboTiG","name":"Mickaël Schoentgen","path":"/BoboTiG","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2033598?s=80&v=4"},"commit":{"message":"Update test_0_watchmedo.py","shortMessageHtmlLink":"Update test_0_watchmedo.py"}},{"before":"ca36d2af495a2c10015ca03cd2b23da5742f869e","after":"8b1726c71f29315a3d2ab88dcebedbaa9f0565d5","ref":"refs/heads/fixes-debouncer","pushedAt":"2024-07-28T14:04:11.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"BoboTiG","name":"Mickaël Schoentgen","path":"/BoboTiG","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2033598?s=80&v=4"},"commit":{"message":"Update src/watchdog/utils/event_debouncer.py","shortMessageHtmlLink":"Update src/watchdog/utils/event_debouncer.py"}},{"before":"85edd94805cf1cebcde04f7871da712fa95acc97","after":"ca36d2af495a2c10015ca03cd2b23da5742f869e","ref":"refs/heads/fixes-debouncer","pushedAt":"2024-07-28T14:00:57.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"BoboTiG","name":"Mickaël Schoentgen","path":"/BoboTiG","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2033598?s=80&v=4"},"commit":{"message":"Update src/watchdog/utils/event_debouncer.py","shortMessageHtmlLink":"Update src/watchdog/utils/event_debouncer.py"}},{"before":"bf1e269e58ef618faca5094d7e691afb9da564ba","after":"f8c9cb080d11126310c00e360e8b432c2d56153c","ref":"refs/heads/fixes-a-possible-race-in-auto-restarter","pushedAt":"2023-08-10T15:07:51.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"ivg","name":"Ivan Gotovchits","path":"/ivg","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2336698?s=80&v=4"},"commit":{"message":"tries an alternative solution\n\ni.e., don't send events if stopped","shortMessageHtmlLink":"tries an alternative solution"}},{"before":null,"after":"bf1e269e58ef618faca5094d7e691afb9da564ba","ref":"refs/heads/fixes-a-possible-race-in-auto-restarter","pushedAt":"2023-08-10T13:52:25.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"ivg","name":"Ivan Gotovchits","path":"/ivg","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2336698?s=80&v=4"},"commit":{"message":"fixes a possible race condition in AutoRestartTrick\n\nJust a long shot for a failure observed on #998. My hypothesis is that\nwhen we stop ProcessWatcher before we restart the process manually, we\ndon't yield to it and immediately kill the process. Next, when the\nProcessWatcher thread is woken up, we have to conditions ready - the\npopen_obj and stopped_event, see the corresponding code, ``` while\nTrue: if self.popen_obj.poll() is not None: break if\nself.stopped_event.wait(timeout=0.1): return ```\n\nAnd desipte that `stopped_event` is set, we first check for\n`popen_obj` and trigger the process restart.\n\nWe can also make the ProcessWatcher logic more robust, by checking if\nwe are stopped before calling the termination callback, e.g.,\n\n```\n        try:\n            if not self.stopped_event.is_set():\n                self.process_termination_callback()\n        except Exception:\n            logger.exception(\"Error calling process termination callback\")\n```\n\nI am not 100% sure about that, as I don't really know what semantics\nis expected from ProcessWatcher by other users. But at least the\nAutoRestarter expects this semantics - i.e., a watcher shall not call\nany events after it was stopped.","shortMessageHtmlLink":"fixes a possible race condition in AutoRestartTrick"}},{"before":"8afb8154b24f0abe0f8f319300d3d1b45f14a207","after":"85edd94805cf1cebcde04f7871da712fa95acc97","ref":"refs/heads/fixes-debouncer","pushedAt":"2023-08-10T13:15:34.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"ivg","name":"Ivan Gotovchits","path":"/ivg","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2336698?s=80&v=4"},"commit":{"message":"simplfies and fixes the debouncer main loop\n\nMakes it more readable and fixes a few issues, see #999 and #1000","shortMessageHtmlLink":"simplfies and fixes the debouncer main loop"}},{"before":null,"after":"8afb8154b24f0abe0f8f319300d3d1b45f14a207","ref":"refs/heads/fixes-debouncer","pushedAt":"2023-08-07T21:18:38.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"ivg","name":"Ivan Gotovchits","path":"/ivg","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2336698?s=80&v=4"},"commit":{"message":"fixes EventDebouncer not producing events\n\nResolves #997","shortMessageHtmlLink":"fixes EventDebouncer not producing events"}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEiy6-KgA","startCursor":null,"endCursor":null}},"title":"Activity · ivg/watchdog"}