Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is banjo reliable enough when using multiple tabs? #29

Open
austin-ralls-cs opened this issue Apr 5, 2021 · 1 comment
Open

Is banjo reliable enough when using multiple tabs? #29

austin-ralls-cs opened this issue Apr 5, 2021 · 1 comment
Labels
binaryninja Issue about Binary Ninja integration improvement Something works but could be better

Comments

@austin-ralls-cs
Copy link
Member

Replacement for #14.

See 2ed32d4
@austin-ralls-cs austin-ralls-cs added binaryninja Issue about Binary Ninja integration improvement Something works but could be better labels Apr 5, 2021
austin-ralls-cs referenced this issue Apr 7, 2021
@austin-ralls-cs
Add initial support for multiple binja tabs
2ed32d4 
This uses UI context notifications to tell which file is in view and
load the relevant disassembly. This is only a heuristic, however,
because if you switch between files while things are still processing or
open two large files quickly, it's possible that it will get confused.
This is a lot better than it was before, but it's not foolproof. I don't
think it's possible to get to 100% just using UI context notifications,
but the heuristics could still at least be improved.

During testing, things were pretty ok, so it's good enough for now.

Close #14 (will open new issue for improvement)
@austin-ralls-cs
Copy link
Member Author

Note that it only works if filenames are unique. Two different files with the same filename (e.g. classes.dex) will completely break if opened in two tabs of the same instance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
binaryninja Issue about Binary Ninja integration improvement Something works but could be better
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@austin-ralls-cs