Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ModelInstance #31

Open
mcdittmar opened this issue Mar 30, 2021 · 2 comments
Open

ModelInstance #31

mcdittmar opened this issue Mar 30, 2021 · 2 comments

Comments

@mcdittmar
Copy link
Collaborator

This element seems to be a 'catch-all' for any modeled data product.
In that regard, it is very similar to Markus' recommendation, where there is an undescribed class where you then "put appropriate object here".

@lmichel
Copy link
Collaborator

lmichel commented Mar 31, 2021

This is a catch-anything-serialized-with-the-same-syntax element

In that regard, it is very similar to Markus' recommendation,

I'm not sure @msdemlei will be enthusiastic with this way to proceed, bu the idea is the similar anyway.

where there is an undescribed class where you then "put appropriate object here".

Exactly, there are 2 use cases that justified this feature:

  • Attach a Provenance to a Mango instance
  • Attach TS/SED/Spectra to a source

It is to be noted that the such associated data can be delivered by web services; in that case, we would have to use WebEnpoint instead of ModelInstance

@mcdittmar
Copy link
Collaborator Author

Right, so this is another case in the discussion about model dependencies.
A more formal approach would be:

  • VOModelInstance references ds:DataProduct
    • requiring that things that can go at ModelInstance (TS|SED|Spectra) extend the ds:DataProduct base class.
    • Note: currently there is a cube:DataProduct, but I've expected to move this as an abstract base in Dataset. (DataProduct references a DatasetMetadata instance). It is extended for SparseCube and NDImage.
    • This is the hook we used in the prototype TS model to accommodate the case type "Time series of Spectra"

For the case I'm currently working.. I am associating a cube (TS/LightCurve) to each Master Source record.
Which is when I noticed that, technically, my TS is not a ModelInstance, so should not be allowed (validation wise).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants