Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new xtype="phrases" #13

Open
pdowler opened this issue Nov 18, 2022 · 4 comments
Open

new xtype="phrases" #13

pdowler opened this issue Nov 18, 2022 · 4 comments

Comments

@pdowler
Copy link
Collaborator

pdowler commented Nov 18, 2022

For use with datatype="char" and arraysize="*" (or more restricted), this xtype would denote a | (pipe) separated list of strings.

require only single space characters within a phrase and no extraneous space adjacent to the separator (canonical form)

allow or require leading and trailing | characters? ivoa.ObsCore.pol_states has leading and trailing sepaarator to make queries work better (although a different separator).

@mbtaylor
Copy link
Member

No strong objection, but can we have an example use case?

@mbtaylor
Copy link
Member

... sorry, I read my github notifications in the wrong order, so answering my own question by reference to ivoa-std/VOTable#25: a list of keywords that might include entries like "dwarf galaxy". Note however that contrary to the suggestion there and here, ObsCore.pol_states uses a solidus "/" not pipe "|" character as the delimiter.

@pdowler
Copy link
Collaborator Author

pdowler commented Nov 21, 2022

I have clarified my use of pol_states as prior art for leading and trailing separator only.

@msdemlei
Copy link
Contributor

...and I remark that epn-tap and regtap both use # as the separator.

Meaning: I don't like it. Let's have a proper array of variable-length strings instead of this hack and #12.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants