Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve parsing error message #32

Merged
merged 1 commit into from Nov 14, 2022
Merged

Conversation

iwahbe
Copy link
Owner

@iwahbe iwahbe commented Nov 14, 2022

This PR significantly improves the readability of parsing error messages.

The old message looked like this:

‘jsonian--path’: Unexpected character ’u’

The new error message looks like this:

jsonian-find: unexpected character ’e’ at 5:14: expecting literal value "true"
  "fizz": [twue, 2, "3", false, { "some": "object" }],
              ^

@iwahbe iwahbe self-assigned this Nov 14, 2022
* Correct handling when text is abridged.
@iwahbe iwahbe force-pushed the iwahbe/improve-error-messages branch from 06c8e33 to b4bcd50 Compare November 14, 2022 02:04
@iwahbe iwahbe merged commit a324bc6 into main Nov 14, 2022
@iwahbe iwahbe deleted the iwahbe/improve-error-messages branch November 14, 2022 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant