Add property to disable in-memory model cache#6
Merged
ragerri merged 4 commits intoixa-ehu:masterfrom May 26, 2017
c-w:master
Merged
Add property to disable in-memory model cache#6ragerri merged 4 commits intoixa-ehu:masterfrom c-w:master
ragerri merged 4 commits intoixa-ehu:masterfrom
c-w:master
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the part-of-speech and lemmatizer models get cached in memory after they've been read from disk. This can lead to very high memory usage, especially if we have a single process that handles requests for many different languages.
This pull request adds a property called
useModelCachethat lets users disable the in-memory caching to reduce the memory usage at the expense of reading more data from disk. By default, the property is enabled so that the public API doesn't change from the previous behavior.