Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency for trailing slash in links from BlogGallery and ProjectList #9

Closed
zzikkzzakk opened this issue May 1, 2023 · 3 comments
Labels
good first issue Good for newcomers

Comments

@zzikkzzakk
Copy link

zzikkzzakk commented May 1, 2023

There is an inconsistent behaviour in links to posts:
From the ProjectList the links have a trailing slash, e.g. /posts/my-post/
in links from BlogGallery there is none, e.g. /posts/my-post

On production I need a trailing slash in all links.
So in astro.config.mjs I had to set
trailingSlash: 'always'
and it worked.

And I had to append the trailing slash in the NavBar links, e.g.
<NavMenuItem href="/posts/">Blog Posts</NavMenuItem>

@ixartz
Copy link
Owner

ixartz commented May 1, 2023

@zzikkzzakk Thank you for suggesting this change. It'll definitively make the output more consistent.

If you want, you can create a PR and I'll merge it.

@ixartz ixartz added the good first issue Good for newcomers label May 8, 2023
@Izocel
Copy link
Contributor

Izocel commented Jun 9, 2023

Some are fixed here
#12

@ixartz
Copy link
Owner

ixartz commented Jun 12, 2023

@Izocel has fixed the issue. Thank you!

@ixartz ixartz closed this as completed Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants