Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add `shell-options` parameter to `use` #33

Open
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@sugarshin
Copy link

commented Jun 30, 2019

Hi, I added shell-options parameter. please review 馃檹

Checklist

  • All new jobs, commands, executors, parameters have descriptions
  • Examples have been added for any significant new features
  • README has been updated, if necessary

Motivation, issues

Useful to be able to select shell options when running custom-logic.

Description

I added shell-options parameter to use. Default is /bin/bash -eo pipefail.

sugarshin added some commits Jun 30, 2019

@@ -86,6 +86,7 @@ The `use` command also takes three optional parameters and one that is technical
| `attach-workspace` | `boolean` | `false` | Attach a workspace for this command to use? Useful when this orb's `reconstruct` job is called upstream in a given workflow |
| `workspace-root` | `string` | "." | Workspace root path (either an absolute path or a path relative to the working directory), defaults to "." (the working directory) |
| `custom-logic` | `string` | echo "What should COMMIT_RANGE ($COMMIT_RANGE) be used for?" | What should be done with the commit information created by the `reconstruct` command/job? [See examples in the orb registry](https://circleci.com/orbs/registry/orb/iynere/compare-url) (or [below](#examples)) |
| `shell-options` | `string` | /bin/bash -eo pipefail | The shell options for `custom-loginc`. Default is `/bin/bash -eo pipefail`. See the document for [using shell scripts](https://circleci.com/docs/2.0/using-shell-scripts/). |

This comment has been minimized.

Copy link
@jscook2345

jscook2345 Jul 8, 2019

custom-loginc?

type: string
default: /bin/bash -eo pipefail
description: >
The shell options for `custom-loginc`. Default is `/bin/bash -eo pipefail`.

This comment has been minimized.

Copy link
@jscook2345

jscook2345 Jul 8, 2019

custom-loginc?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.