Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Improve implementation of Vorsorgeaufwand #709

Open
MImmesberger opened this issue Mar 15, 2024 · 0 comments
Open

ENH: Improve implementation of Vorsorgeaufwand #709

MImmesberger opened this issue Mar 15, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@MImmesberger
Copy link
Collaborator

Is your feature request related to a problem?

Currently, the Vorsorgeaufwand module is not up to date with our current machinery. In particular, time conversions happen manually and the naming of functions is unclear to a point where the DAG is not comprehensible from looking at the function definitions.

For example, we define:

@dates_active(
    start="2005-01-01", end="2019-12-31", change_name="vorsorgeaufw_y_sn_bis_2004"
)
def _vorsorgeaufw_y_sn_bis_2004(

Describe the solution you would like to see

Make time conversions outside of functions. Improve function names.

@MImmesberger MImmesberger added the enhancement New feature or request label Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant