From 9b7ba248031b93673ccfa1e5eeb4667bb4e389c4 Mon Sep 17 00:00:00 2001 From: Izel Nakri Date: Fri, 15 Jul 2016 17:20:20 +0200 Subject: [PATCH] originator field removed from the paper_trail library --- NOTES.md | 1 + example/priv/repo/migrations/20160715134921_add_versions.exs | 1 - example/test/company_test.exs | 5 +---- lib/mix/tasks/papertrail/install.ex | 1 - lib/version.ex | 5 ++--- priv/repo/migrations/20160619190936_add_versions.exs | 1 - 6 files changed, 4 insertions(+), 10 deletions(-) create mode 100644 NOTES.md diff --git a/NOTES.md b/NOTES.md new file mode 100644 index 00000000..7ce4e350 --- /dev/null +++ b/NOTES.md @@ -0,0 +1 @@ +originator is optional on the PaperTrail.Version.meta field diff --git a/example/priv/repo/migrations/20160715134921_add_versions.exs b/example/priv/repo/migrations/20160715134921_add_versions.exs index 425473bc..d213ef48 100644 --- a/example/priv/repo/migrations/20160715134921_add_versions.exs +++ b/example/priv/repo/migrations/20160715134921_add_versions.exs @@ -8,7 +8,6 @@ defmodule Repo.Migrations.AddVersions do add :item_id, :integer add :item_changes, :map add :meta, :map - add :originator, :string add :inserted_at, :datetime, null: false end diff --git a/example/test/company_test.exs b/example/test/company_test.exs index 6e51f6f6..a33efdf2 100644 --- a/example/test/company_test.exs +++ b/example/test/company_test.exs @@ -45,15 +45,12 @@ defmodule CompanyTest do founded_in: nil } - version |> inspect |> IO.puts - assert Map.drop(version, [:id]) == %{ event: "create", item_type: "Company", item_id: Repo.one(first(Company, :id)).id, item_changes: Map.drop(result[:model], [:__meta__, :__struct__]), - meta: nil, - originator: nil + meta: nil } end diff --git a/lib/mix/tasks/papertrail/install.ex b/lib/mix/tasks/papertrail/install.ex index c1f1cb99..905180c2 100644 --- a/lib/mix/tasks/papertrail/install.ex +++ b/lib/mix/tasks/papertrail/install.ex @@ -22,7 +22,6 @@ defmodule Mix.Tasks.Papertrail.Install do add :item_id, :integer add :item_changes, :map add :meta, :map - add :originator, :string add :inserted_at, :datetime, null: false end diff --git a/lib/version.ex b/lib/version.ex index f5ba8be6..618ca86d 100644 --- a/lib/version.ex +++ b/lib/version.ex @@ -13,13 +13,12 @@ defmodule PaperTrail.Version do field :item_id, :integer field :item_changes, :map field :meta, :map - field :originator, :string timestamps(updated_at: false) end - @required_fields ~w(item_type item_id event created_at) - @optional_fields ~w(meta originator) + @required_fields ~w(event item_type item_id created_at) + @optional_fields ~w(meta) @doc """ Creates a changeset based on the `model` and `params`. diff --git a/priv/repo/migrations/20160619190936_add_versions.exs b/priv/repo/migrations/20160619190936_add_versions.exs index 425473bc..d213ef48 100644 --- a/priv/repo/migrations/20160619190936_add_versions.exs +++ b/priv/repo/migrations/20160619190936_add_versions.exs @@ -8,7 +8,6 @@ defmodule Repo.Migrations.AddVersions do add :item_id, :integer add :item_changes, :map add :meta, :map - add :originator, :string add :inserted_at, :datetime, null: false end