-
-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for issue #8, added ASCII to HEX and HEX to ASCII converters #10
Conversation
Updated version info Added functions to options page
��`:q
This reverts commit ce1328b.
Thanks for your PR. Just looking at it it seems fine, didn't have time to test though. There's a few things for code quality that could be better though. There's a few tabs and mixed tabs/spaces which garble the code indentation. Other than that I can't see any problems that'd prevent merging it. |
@mkzero oh sorry about that, my editor probably couldn't figure out what the code style was, adding an editorconfig could be useful for future pull requests |
Tested using the following input:
ASCII to HEX
HEX to ASCII