Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue #8, added ASCII to HEX and HEX to ASCII converters #10

Closed
wants to merge 61 commits into from

Conversation

Paradoxis
Copy link
Contributor

Tested using the following input:

ASCII to HEX

Say Hello to My Little Friend -> 5361792048656c6c6f20746f204d79204c6974746c6520467269656e64

HEX to ASCII

5361792048656c6c6f20746f204d79204c6974746c6520467269656e64 -> Say Hello to My Little Friend
53 61 79 20 48 65 6c 6c 6f 20 74 6f 20 4d 79 20 4c 69 74 74 6c 65 20 46 72 69 65 6e 64 -> Say Hello to My Little Friend
53-61-79-20-48-65-6c-6c-6f-20-74-6f-20-4d-79-20-4c-69-74-74-6c-65-20-46-72-69-65-6e-64 -> Say Hello to My Little Friend
\x53\x61\x79\x20\x48\x65\x6c\x6c\x6f\x20\x74\x6f\x20\x4d\x79\x20\x4c\x69\x74\x74\x6c\x65\x20\x46\x72\x69\x65\x6e\x64 -> Say Hello to My Little Friend 

@Paradoxis Paradoxis changed the title Fix for issue #7, added ASCII to HEX and HEX to ASCII converters Fix for issue #8, added ASCII to HEX and HEX to ASCII converters Feb 15, 2017
@Paradoxis Paradoxis mentioned this pull request Feb 15, 2017
@izzy
Copy link
Owner

izzy commented Feb 15, 2017

Thanks for your PR. Just looking at it it seems fine, didn't have time to test though.

There's a few things for code quality that could be better though. There's a few tabs and mixed tabs/spaces which garble the code indentation. Other than that I can't see any problems that'd prevent merging it.

@Paradoxis
Copy link
Contributor Author

@mkzero oh sorry about that, my editor probably couldn't figure out what the code style was, adding an editorconfig could be useful for future pull requests

@izzy izzy closed this Jul 4, 2019
izzy added a commit that referenced this pull request Sep 14, 2019
izzy added a commit that referenced this pull request Sep 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants