Navigation Menu

Skip to content
This repository has been archived by the owner on Jul 18, 2022. It is now read-only.

Should we use anything from tomthebotter's copy #79

Closed
wants to merge 0 commits into from

Conversation

sontek
Copy link
Collaborator

@sontek sontek commented Jul 25, 2016

There seems to be a lot of weird changes, but there might be some good stuff in here as well.. Just opening this PR up so we can review/discuss.

@jekirl jekirl changed the title this is the tomthebotter code Should we use anything from tomthebotter's copy Jul 25, 2016
@jekirl
Copy link
Owner

jekirl commented Jul 25, 2016

I don't see any substantive changes from a quick glance but I could be very mistaken! Looks mostly like pieces of the code base from different points in time (with slight changes to style, etc?)

IF you see anything please add a comment in the commit so I can check it out.

Thanks 😄

@sontek
Copy link
Collaborator Author

sontek commented Jul 25, 2016

@J-e-k The one thing he added recently in the configuration which is kind of nice is it returning to start position after so much distance. That way you don't wander the world but stay close to a certain area (i.e if you like water pokemon... staying close to that)

@sontek
Copy link
Collaborator Author

sontek commented Jul 25, 2016

I'm just going to close this and start working off your codebase to add the features I want :)

@sontek sontek closed this Jul 25, 2016
@beeedy
Copy link
Contributor

beeedy commented Jul 26, 2016

@sontek, the ability to have it return to a specific location is very nice to also avoid softbans and is probably a worthwhile addition.

I had an addition that added the ability to automatically transfer duplicate pokemon for those of us more interested in collecting a variety and not necessarily the strongest possible set. I have made some changes and submitted a PR for this specifically
#80

@jekirl
Copy link
Owner

jekirl commented Jul 26, 2016

The return to specific location was recently added by @wesselvdv I believe In #63

Haven't checked it out myself yet though

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants