Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Good job! #2

Closed
simosentissi opened this Issue Nov 11, 2014 · 5 comments

Comments

3 participants
@simosentissi
Copy link

simosentissi commented Nov 11, 2014

just stumbled on this library, this is really good work!

@benas

This comment has been minimized.

Copy link
Collaborator

benas commented Nov 11, 2014

Thanks! I am glad you like it :-)

@simosentissi

This comment has been minimized.

Copy link
Author

simosentissi commented Nov 11, 2014

You filled the space between a drools like engine and a custom predicate model. that is very good and unique.

I would suggest to add to the how-to any verbiage to immutability -just for awareness/guidance sake-: I can see quiet a few folks using this in a web app and they might be wondering about that aspect.

You will be pleasantly surprised on how many folks do not get engines like drools, but would go with something like this instead and realize that is exactly what they needed :)

Cheers!
-Simo

@benas

This comment has been minimized.

Copy link
Collaborator

benas commented Nov 11, 2014

I have seen many folks (under)using full blown rules engines for very basic requirements, just like using a hammer to kill a fly :-) and this is why I developed Easy Rules.

The point about immutability is very important indeed, I will consider mentioning it in documentation for next release. If you like to contribute it, you are welcome.

Keep tuned.
Regards,
Mahmoud

@drem-darios

This comment has been minimized.

Copy link
Contributor

drem-darios commented Feb 11, 2015

Great library! I agree this is a nice simple and lightweight solution between drools and a custom predicate. I had to fork and remove the JMX support to use this library with Android though. The java.lang.management library depends on the JVM which Android doesn't use. Just thought I would mention this. Cheers!

@benas

This comment has been minimized.

Copy link
Collaborator

benas commented Feb 12, 2015

Hi @drem-darios
Thank you, I'm glad you liked it :-)

I was not aware that the JMX API is not supported on Android and I understand why you had to fork Easy Rules. You have removed all the JMX related code from the engine but there still the @MXBean annotation on the Rule interface in your fork. Is this ok with Android? There still a JMX import for this annotation. Does Android can run easy rules with this annotation present?

This is important because, if so, I have to redesign Easy Rules to make the JMX reconfiguration feature optional so that the core engine can be used in Java and Android. I have to provide a better design so that users should not fork the project and remove a feature, they should instead fork the project to add a feature maybe (Open-Closed principle)

Regards
Mahmoud

PS: I just posted this message on gitter. I think it's a better place to continue this discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.