Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting priors #16

Open
j-faria opened this issue Dec 5, 2017 · 1 comment
Open

Setting priors #16

j-faria opened this issue Dec 5, 2017 · 1 comment

Comments

@j-faria
Copy link
Owner

j-faria commented Dec 5, 2017

My original goal for how to set the priors was

  • there's a default set of priors, which we can use with `#include "default_priors.h"
  • after doing that, the user could change a few priors individually, either inside or outside of the RVmodel constructor, depending on whether they depend on the data

But that has created a few complications and was the cause of #13 and #15 at least.
So I was thinking of refactoring things to be able to do

#include "default_extra_priors.h"  // sets Cprior, Jprior, maybe slope_prior
#include "default_GP_priors.h"  // sets the eta priors
#include "default_planet_priors.h"  // P, K, e, phi and w priors
#include "default_hyper_priors.h"  // sets log_muP_prior, wP_prior, log_muK_prior

Maybe the last include should also set P and K priors, but it will get confusing fast...
Let's use this issue to discuss

@eggplantbren
Copy link
Collaborator

eggplantbren commented Dec 5, 2017

Hmm. I think the best way to set all the options would be to have a type (class) with all the settings in it, and handle all the specific sets of settings when needed by looking up the contents of the settings object. That would be a lot of work, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants