Fix buildsystem #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… ‘;’ Since starting with VTK7, vtkStandardNewMacro expects vtkObjectFactory.h, this commit add the missing include.
This commit fixes the following warnings:
```
/tmp/ModelClip/qSlicerModelClipModuleWidget.cxx: In member function ‘void qSlicerModelClipModuleWidget::removePlane()’:
/tmp/ModelClip/qSlicerModelClipModuleWidget.cxx:229:11: warning: unused variable ‘index’ [-Wunused-variable]
int index = this->planeList.indexOf(this->planeList.last());
^
/tmp/ModelClip/qSlicerModelClipModuleWidget.cxx: In member function ‘void qSlicerModelClipModuleWidget::setDepth()’:
/tmp/ModelClip/qSlicerModelClipModuleWidget.cxx:326:13: warning: unused variable ‘axisNorm’ [-Wunused-variable]
double *axisNorm = new double[3];
```
This commit fixes the following errors:
```
/tmp/ModelClip/qSlicerModelClipModuleWidget.cxx:379:17: error: ‘class vtkClipPolyData’ has no member named ‘SetInput’
this->clipper->SetInput(this->sourcePD);
^
/tmp/ModelClip/qSlicerModelClipModuleWidget.cxx:429:17: error: ‘class vtkMRMLModelDisplayNode’ has no member named ‘SetInputPolyData’
resultDisplay->SetInputPolyData(resultModel->GetPolyData());
^
/tmp/ModelClip/qSlicerModelClipModuleWidget.cxx:453:18: error: ‘class vtkMRMLModelDisplayNode’ has no member named ‘SetInputPolyData’
clippedDisplay->SetInputPolyData(clippedModel->GetPolyData());
^
```
This commit fixes the following warnings:
```
/tmp/ModelClip/vtkPlaneExtend.cxx: In member function ‘void vtkPlaneExtend::MovePoint3(double*, double*)’:
/tmp/ModelClip/vtkPlaneExtend.cxx:776:10: warning: unused variable ‘d1’ [-Wunused-variable]
double d1 = (vN/n10) * vtkMath::Dot(v,p10) / (vN*n10);
^
/tmp/ModelClip/vtkPlaneExtend.cxx:779:10: warning: unused variable ‘point1’ [-Wunused-variable]
double point1[3], point2[3];
^
/tmp/ModelClip/vtkPlaneExtend.cxx: In member function ‘void vtkPlaneExtend::Rotate(double*, double*, double*)’:
/tmp/ModelClip/vtkPlaneExtend.cxx:796:11: warning: unused variable ‘center’ [-Wunused-variable]
double *center = this->PlaneSource->GetCenter();
^
/tmp/ModelClip/vtkPlaneExtend.cxx: At global scope:
/tmp/ModelClip/vtkPlaneExtend.cxx:791:61: warning: unused parameter ‘vpn’ [-Wunused-parameter]
void vtkPlaneExtend::Rotate(double *p1, double *p2, double *vpn)
^
```
This commit fixes the following warning:
```
/tmp/ModelClip/vtkPlaneExtend.cxx: In member function ‘void vtkPlaneExtend::GetPoint3(double*)’:
/tmp/ModelClip/vtkPlaneExtend.cxx:1082:44: warning: parameter ‘xyz’ set but not used [-Wunused-but-set-parameter]
void vtkPlaneExtend::GetPoint3(double xyz[3])
^
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.