Permalink
Switch branches/tags
Nothing to show
Commits on Mar 9, 2010
Commits on Mar 8, 2010
  1. Merge branch 'task_templates'

    Anatoliy Lysenko committed Mar 8, 2010
  2. link_to_task return link to tasks or tasks_templates controller based…

    Anatoliy Lysenko committed Mar 8, 2010
    … on first argument class.
  3. Add "Create task from this template" button to task template edit pag…

    Anatoliy Lysenko committed Mar 8, 2010
    …e. Unobtrusive onclick handler change form action to tasks/create. When user click "Create task from this template", request sended to TasksController#create, so one task creation code work in both cases(from tasks/new and from template).
  4. Add choices "Templates" and "New Template" to "Tasks" menu.

    Anatoliy Lysenko committed Mar 8, 2010
  5. Cleanup results of unclean rebase.

    Anatoliy Lysenko committed Mar 8, 2010
  6. Merge branch 'master' of git://github.com/ari/clockingit

    Anatoliy Lysenko committed Mar 8, 2010
  7. Fix redirect: when update task template, must redirect to task_templa…

    Anatoliy Lysenko committed Mar 8, 2010
    …tes/list instead of tasks/list.
  8. Fix typo in TasksController.

    Anatoliy Lysenko committed Mar 8, 2010
  9. Fix typo in TasksController.

    Anatoliy Lysenko committed Mar 8, 2010
  10. Templates have not read/unread status.

    Anatoliy Lysenko committed Mar 8, 2010
  11. Rewrite TasksController#current_company_task_find in TaskTemplatesCon…

    Anatoliy Lysenko committed Mar 8, 2010
    …troller#current_company_task_find to return templates. This method used in TasksController add_client, add_user_for_client, add_client_for_project. Now this TaskTemplatesController add_client, add_user_for_client, add_client_for_project work fine with templates.
  12. TasksController#list: render templates from views/tasks, even if requ…

    Anatoliy Lysenko committed Mar 7, 2010
    …est comme to TaskTemplatesController#list.
  13. In TasksController#edit render templates from views/tasks, even if re…

    Anatoliy Lysenko committed Mar 6, 2010
    …quest comme to TaskTemplatesController#edit.
  14. Add part of test for TaskTemplatesController#update.

    Anatoliy Lysenko committed Mar 6, 2010
  15. Extract call to Task model into TasksController#controlled_model. Rew…

    Anatoliy Lysenko committed Mar 6, 2010
    …rite TaskTemplatesController#controlled_model to return Template instead of a Task. This all is part of design pattern "Template Method"(do not miss with task templates).
  16. Extract finding of task in TasksController#edit into TasksController#…

    Anatoliy Lysenko committed Mar 5, 2010
    …curren_company_task_find_by_task_num. Rewrite it in TasksTemplateController to return instance of Template instead of instance of Task.
  17. Small fixes in tasks controller and tasks_templates controller test. …

    Anatoliy Lysenko committed Mar 5, 2010
    …Test for task template creation finally passed.
  18. Use full name of partial in tasks_helper, so TasksTemplatesController…

    Anatoliy Lysenko committed Mar 4, 2010
    … don't raise TemplateMissing error.
  19. Fix typo in TaskTemplatesControllerTest.

    Anatoliy Lysenko committed Mar 4, 2010
  20. Small fix in TasksTemplatesController test.

    Anatoliy Lysenko committed Mar 4, 2010
  21. Rewrite TasksController#big_fat_controller_method and TasksController…

    Anatoliy Lysenko committed Mar 4, 2010
    …#create_worklogs_for_tasks_create in TasksTemplateController to empty functions. Because templates don't need all this stuff.
  22. Refactoring: extract worklogs creation from TasksController#create in…

    Anatoliy Lysenko committed Mar 4, 2010
    …to TasksController#create_worklogs_for_tasks_create. Now we can create task without creating worklogs - just rewrite create_worklogs_for_tasks_create method.
  23. Refactoring: extract code from TasksController#update to TasksControl…

    Anatoliy Lysenko committed Mar 4, 2010
    …ler#big_fat_method. This method must be refactored into another methods.
  24. Rewrite TasksController#current_company_task_new in TaskTemplatesCont…

    Anatoliy Lysenko committed Mar 4, 2010
    …roller to create instance of Template instead of a task. Now TaskTemplatesController#new and TaskTemplatesController#update(inherited from TaskController) will use TaskTemplatesController#current_company_task_new instead of TasksController#current_company_task_new. This is example of design pattern "Template method".
  25. Small fix in WorkLog#build_work_added_or_comment: avoid cloning nil o…

    Anatoliy Lysenko committed Mar 4, 2010
    …bject.
  26. Extract task creation from TasksController new/create actions in to c…

    Anatoliy Lysenko committed Mar 4, 2010
    …urrent_company_task_new. This will reduce code duplication and add ability to redefine task creation in TasksController's subclasses.
  27. Remove params[:task] from new action. tasks/new accepted only via GET…

    Anatoliy Lysenko committed Mar 4, 2010
    … withou any params. I think this code was copy-pasted from another action.
  28. Rewrite partial tasks/_new_comment in task_templates/_new_comment. No…

    Anatoliy Lysenko committed Mar 4, 2010
    …w user can not add comments to template.
  29. Extract worktime container from tasks/_new_comment.html.erb into task…

    Anatoliy Lysenko committed Mar 3, 2010
    …s/_worktime_container.html.erb. Rewrite task_templates/_worktime_container.html.erb to empty, because templates don't have work times.
  30. Refactoring TasksController#update: move extract code to another meth…

    Anatoliy Lysenko committed Mar 3, 2010
    …ods. TasksController must be more modular, to be good parent for TaskTemplatesController.
  31. Add hooks for actions that defined in TasksController, but unused in …

    Anatoliy Lysenko committed Mar 3, 2010
    …TaskTemplatesController. Now they just raise exception. This is only for developmnent and must be cleaned when we put task templates in production.
  32. Remove code added by mistake in a063054 commit.

    Anatoliy Lysenko committed Mar 3, 2010