--not-when-fullscreen... again

[jD91mZM2]

I'm having a similar issue, I think. If Firefox is fullscreen it will still trigger the screenlock. If audio is running it will still trigger screen dimming but not lock.

#! /bin/bash

# Run xidlehook
xidlehook \
  `# but not when fullscreen` \
  --not-when-fullscreen \
  `# and not when audio playing` \
  --not-when-audio \
  `# dim after 60 seconds inactivity, undim if activity` \
  --timer normal 60 \
    'xrandr --output HDMI2 --brightness .4 --output VGA1 --brightness .4' \
    'xrandr --output HDMI2 --brightness 1 --output VGA1 --brightness 1' \
  `# after ten seconds undim and run gllock` \
  --timer primary 15 \
    'xrandr --output HDMI2 --brightness 1 --output VGA1 --brightness 1; gllock' \
    '' \
  `#if no activity in another 30 seconds suspend `\
    --timer normal 60 \
      'systemctl suspend'\
      ''

Originally posted by @stevensonmt in #5 (comment)

[jD91mZM2]

What DE/WM are you using? This has occured to me in xmonad due of a lack of EWMH hints.

To debug this, please run the following command and click a fullscreen window.

xprop | grep _NET_WM_STATE

EDIT: Oh, and xidlehook version would be great!

[stevensonmt]

WM is leftwm. Will update with other info when I get home again, but I did check that xprop showed the _NET_WM_STATE_FULLSCREEN property before adding my comment.

[stevensonmt]

~/ xprop | grep _NET_WM_STATE
_NET_WM_STATE(ATOM) = _NET_WM_STATE_FULLSCREEN, _NET_WM_STATE_MAXIMIZED_HORZ, WM_COLORMAP_WINDOWS

~/ xidlehook --version
xidlehook 0.7.1

[jD91mZM2]

I assume the window is the selected one? See #19

[stevensonmt]

yes, it is the focused window.

[jD91mZM2]

I'm afraid I don't have much time to debug this at the moment, especially since I can't reproduce it :(

If you'd like, you can spray some dbg!()s everywhere in

xidlehook/src/main.rs

Line 416 in 152d057

fn step(&mut self) -> Result<Status, Error> {

. Once you reach a conclusion to what the issue is, I'll be happy to reproduce the bug for myself and fix it.

[stevensonmt]

I'm going to be out of touch for the next week or so but when I get back I'll give it a look and see if I can figure it out. Thanks.

[stevensonmt]

Just wondering if you could help me understand this bit of code from x11api.rs:

    // Get the window properties of said window
    let mut data: *mut u8 = ptr::null_mut();
    let mut nitems = 0;
    XGetWindowProperty(
        display,
        focus,
        XInternAtom(display, NET_WM_STATE.as_ptr() as *const c_char, 0),
        0,
        c_long::max_value(),
        0,
        XA_ATOM,
        ignored_ulong,
        ignored_int,
        &mut nitems,
        ignored_ulong,
        &mut data
    );

    let data = XIntPtr(data as *mut _);
    let atom = XInternAtom(
        display,
        NET_WM_STATE_FULLSCREEN.as_ptr() as *const c_char,
        0
    );

    // Check the list of returned items for _NET_WM_STATE_FULLSCREEN
    for i in 0..nitems as isize {
        if *data.0.offset(i) == atom {
            return Ok(true);
        }
    }

I don't see where nitems is incremented. If it is not incremented does the check never happen?

[jD91mZM2]

Of course!

Both nitems and data are set by XGetWindowProperty, assuming the call succeeds. I should actually have some error handling there, I guess.

A good sanity check would be to add dbg!(nitems) somewhere after that call to make sure it prints out 3 for a fullscreen window. Then print out the element values and the value of atom which is what it's searching for.

[stevensonmt]

So I've tried with chromium and firefox running fullscreen. With chromium fullscreen dbg!(nitems) returns nitems = 2 (not at fullscreen it returns nitems = 1), but with firefox in either fullscreen or not I get nitems = 0. In all cases atom = 349.

The above is with leftwm. With XFCE firefox at fullscreen also returns nitems = 2.

I only get nitems = 3 if the terminal window running xidlehook is at fullscreen or even if it is just maximized. Otherwise results are very inconsistent.
In this screenshot firefox is fullscreen the entire time and nitems goes from 2 to 0 for some reason.

It later went back to 2 and then back to 0 depending on which window had focus (terminal focus => 2, FF focus => 0) regardless of the FF fullscreen status.

With chromium in XFCE I get nitems of 3 for maximized or 4 for fullscreen after maximized. I get 2 if not maximized or fullscreen but 3 if fullscreen from a non-maximized state.

[jD91mZM2]

Amazingly debugged :)! When you ran xprop | grep _NET_WM_STATE, did you make sure Firefox was fullscreen and focused?

[stevensonmt]

Not sure, but just did it again and got

>> sleep 3 && xprop | grep _NET_WM_STATE
_NET_WM_STATE(ATOM) = _NET_WM_STATE_MAXIMIZED_VERT, _NET_WM_STATE_FULLSCREEN, _NET_WM_STATE_FOCUSED

The sleep was so I could use the mouse to focuse FF before xprop ran. The output was the same when chromium is fullscreen and focused.

That was with XFCE. With leftwm the output is less verbose (but again identical for FF and chromium):

>>sleep 3 && xprop | grep _NET_WM_STATE
_NET_WM_STATE(ATOM) = _NET_WM_STATE_FULLSCREEN

[jD91mZM2]

What's the output if you replace

if *data.0.offset(i) == atom {

with

if dbg!(*data.0.offset(i)) == atom {

?

[stevensonmt]

Zeroes with firefox fullscreen or not, focused or not.
1 with chromium fullscreen, focused or not.

[jD91mZM2]

Only thing I can think of is wrapping those XGetInputFocus(...) and XGetWindowProperty(...) calls in dbg!, in case one of them is returning an error. Otherwise, none of this output makes sense to me :(