Untar demo works in IE7 again #37

Merged
merged 2 commits into from Apr 5, 2013

Projects

None yet

3 participants

@RReverser
Member

No description provided.

@micshr
micshr commented Apr 3, 2013

Thanks a lot! It works now. I guess the html should have $.get('jquery.tar', tar, 'dataview');

@RReverser
Member

@micshr It should if it would use @vjeux's patch, but instead it just uses newer version of jQuery and works pretty well with it even w/o patch.

@RReverser
Member

But you may use patch if you want jQuery to return jDataView directly. Difference is one extra call of new jDataView(data) :)

@micshr
micshr commented Apr 3, 2013

I'll try without the patch, less maintaining. thanks!

@micshr
micshr commented Apr 3, 2013

I guess, you still need the jQuery binary patch for, IE7 and IE8... Without the patch I get byteLength == 4 instead of 204800.

@RReverser
Member

Very strange because I get 204800 in IE7.

@micshr
micshr commented Apr 3, 2013

Wierd, I'm using the latest jQuery:

<script src="../../jquery/jquery-1.9.1.js"></script>

u r sure not using jquery-1.7.1-binary-ajax.js?

@RReverser
Member

I'm sure I do use it )
Saying patch I didn't mean binary one, but jQuery extension that was in jdataview.js - 26ad259.

@micshr
micshr commented Apr 3, 2013

Aah, ok , got it :-)

@vjeux vjeux merged commit 062b5dd into jDataView:master Apr 5, 2013
@vjeux
Member
vjeux commented Apr 5, 2013

@RReverser: Do you mind putting the code you deleted in 26ad259 in a file so people can use it?

@RReverser
Member

@vjeux Though about (and tried) putting that code into file jquery.jdataview.js, but as was said in comments, with new jQuery that code is not needed (works even without it).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment