Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

result of rayTest #1027

Closed
HelloWorldlsla opened this Issue Feb 26, 2019 · 4 comments

Comments

Projects
None yet
2 participants
@HelloWorldlsla
Copy link

commented Feb 26, 2019

Hello

Can someone make a quick change?
I'm talking about the function rayTest() and rayTestRaw() of the class PhysicsSpace.

Instead of returning a simple List, I suggest to return a List of PhysicsRayTestResult.
Look like this:

public List<PhysicsRayTestResult> rayTest() {}
instead of this:
public List rayTest() {}

And the same for the rayTestRaw method:
public List<PhysicsRayTestResult> rayTestRaw() {}
instead of this:
public List rayTest() {}

Why?
Beacause in IntelliJ IDEA (I don't know how it looks in other IDEs) casting
a List to a List<PhysicsRayTestResult> make the line colored yellow.
And guys like me don't like colored lines...

Regards

@stephengold stephengold self-assigned this Feb 27, 2019

@stephengold stephengold added this to the v3.2.3 milestone Feb 27, 2019

@stephengold

This comment has been minimized.

Copy link
Contributor

commented Feb 27, 2019

This issue exists only with jme3-bullet library. In jme3-jbullet, the return type is more precise.

stephengold added a commit that referenced this issue Feb 27, 2019

@stephengold

This comment has been minimized.

Copy link
Contributor

commented Feb 27, 2019

Fixed in master branch at 15f9f69 .

@HelloWorldlsla

This comment has been minimized.

Copy link
Author

commented Feb 27, 2019

Hi stephengold
Thanks for this update, but....
I think you forgot to change the result of the rayTestRaw()method :)
At line 1021

Have a good day!

stephengold added a commit that referenced this issue Feb 27, 2019

@stephengold

This comment has been minimized.

Copy link
Contributor

commented Feb 27, 2019

You're right! I think the fix is now complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.