Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AnimComposer.getAnimClips() and .getAnimClipsNames() should return sets, not collections #1070

Closed
stephengold opened this issue Apr 13, 2019 · 3 comments

Comments

Projects
None yet
2 participants
@stephengold
Copy link
Contributor

commented Apr 13, 2019

Currently in com.jme3.anim (new animation system) the AnimComposer control defines 2 methods to enumerate all clips contained in the composer. While both methods return collections, the implementation does not allow the same AnimClip to be added twice. It would be advantageous to return sets instead, to clarify that duplicates are not allowed.

@rvandoosselaer

This comment has been minimized.

Copy link
Contributor

commented Apr 17, 2019

I'll tackle this issues this evening.

rvandoosselaer added a commit to rvandoosselaer/jmonkeyengine that referenced this issue Apr 17, 2019

returns an unmodifiable set when retrieving the available animation n…
…ames and available animation clips instead of an unmodifiable collection. fixes: jMonkeyEngine#1070
@stephengold

This comment has been minimized.

Copy link
Contributor Author

commented Apr 20, 2019

Removed getAnimClips() from the scope of this issue, per discussion at PR #1071.

stephengold added a commit that referenced this issue Apr 22, 2019

returns unmodifiable sets (#1071)
* returns an unmodifiable set when retrieving the available animation names and available animation clips instead of an unmodifiable collection. fixes: #1070

* remove unnecessary set wrapper.
@stephengold

This comment has been minimized.

Copy link
Contributor Author

commented Apr 24, 2019

The issue is open until #1076 gets integrated.

@stephengold stephengold reopened this Apr 24, 2019

@stephengold stephengold added this to the v3.3.0 milestone Jun 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.